#167703750 change on authorisation #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#165413102 User should be able to logout
…into develop pull origin develop
…into develop pull origin develop
houndci-bot
reviewed
Aug 5, 2019
helpers/commentHelper.js
Outdated
| currentComment.dataValues.histories = commentHistories; | ||
| return currentComment; | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
helpers/commentHelper.js
Outdated
| currentComment.dataValues.histories = commentHistories; | ||
| return currentComment; | ||
| })); | ||
| await Promise.all( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
controllers/article.controller.js
Outdated
| const numberOfSharesOnPlatform = await ArticleHelper.numberOfSharesOnPlatform(shares); | ||
| const numberOfSharesOnPlatform = await ArticleHelper.numberOfSharesOnPlatform( | ||
| shares | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
controllers/article.controller.js
Outdated
| @@ -238,7 +238,9 @@ class ArticleController { | |||
| .status(200) | |||
| .send({ message: 'this article has not been shared yet' }); | |||
| } | |||
| const numberOfSharesOnPlatform = await ArticleHelper.numberOfSharesOnPlatform(shares); | |||
| const numberOfSharesOnPlatform = await ArticleHelper.numberOfSharesOnPlatform( | |||
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
-user can get ratings, likes AND dislikes on an article while not authenticated. [delivers #167703750]
Kabalisa
force-pushed
the
ch-change-on-authorisation-167703750
branch
from
63b2e07
to
698a54a
Compare
AJAkimana
approved these changes
Aug 7, 2019
ericnyirimana
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
a user should be able to see the ratings, likes, and dislikes on an article even when they are not authenticated.
How has it been tested
npm testChecklist:
N/A
Pivotal tracker story ID
#167703750