#167785593 Add filters #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Aug 8, 2019
helpers/article.js
Outdated
| highlight.dataValues.comments = comments; | ||
| return highlight; | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
helpers/article.js
Outdated
| highlight.dataValues.comments = comments; | ||
| return highlight; | ||
| })); | ||
| await Promise.all( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
helpers/article.js
Outdated
| const result = await open(`https://www.linkedin.com/sharing/share-offsite/?url=${articleShareUrl}`); | ||
| const result = await open( | ||
| `https://www.linkedin.com/sharing/share-offsite/?url=${articleShareUrl}` | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
helpers/article.js
Outdated
| return result; | ||
| } | ||
| if (option === 'linkedin') { | ||
| const result = await open(`https://www.linkedin.com/sharing/share-offsite/?url=${articleShareUrl}`); | ||
| const result = await open( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
helpers/article.js
Outdated
| const result = await open(`https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=&su=Authorshaven%20Post&body=copy%20the%20following%20link%20to%20open%20the%20article%20${articleShareUrl}`); | ||
| const result = await open( | ||
| `https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=&su=Authorshaven%20Post&body=copy%20the%20following%20link%20to%20open%20the%20article%20${articleShareUrl}` | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
helpers/article.js
Outdated
| @@ -615,11 +587,15 @@ class ArticleHelper { | |||
| return result; | |||
| } | |||
| if (option === 'gmail') { | |||
| const result = await open(`https://mail.google.com/mail/?view=cm&fs=1&tf=1&to=&su=Authorshaven%20Post&body=copy%20the%20following%20link%20to%20open%20the%20article%20${articleShareUrl}`); | |||
| const result = await open( | |||
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
helpers/article.js
Outdated
| articleId: article.dataValues.id | ||
| }); | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
helpers/article.js
Outdated
| articleId: article.dataValues.id | ||
| }); | ||
| })); | ||
| await Promise.all( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
- Add orderby for articles and notifications - Add category in articles - Add information into token [Finishes #167785593]
jabichris
force-pushed
the
ch-improve-backend-167785593
branch
from
90feee9
to
4b602a3
Compare
Niyitangasam
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for adding the categories for article, increase information kept in token
How has it been tested
N/A
Checklist:
Pivotal tracker story ID
#167785593