Refactor codebase

Increase test coverage
Use consistent class definitions in files

package.json

@@ -5,14 +5,14 @@
   "main": "index.js",
   "scripts": {
     "coverage": "nyc report --reporter=text-lcov | coveralls",
-    "test": "NODE_ENV=test yarn undo-migration && NODE_ENV=test yarn migrate && NODE_ENV=test yarn seed && NODE_ENV=test nyc --reporter=html --reporter=text mocha --exit --require @babel/register --require @babel/polyfill src/test/index.js",
+    "test": "NODE_ENV=test yarn undo:migration && NODE_ENV=test yarn migrate && NODE_ENV=test yarn undo:seed && NODE_ENV=test yarn seed && NODE_ENV=test nyc --reporter=html --reporter=text mocha --exit --require @babel/register --require @babel/polyfill src/test/index.js",
     "coveralls": "nyc report --reporter=text-lcov | coveralls",
     "dev-start": "NODE_ENV=development nodemon --exec babel-node src/index.js",
     "build": "babel src --out-dir build",
     "start": "node build/index.js",
-    "undo-seeding": "./node_modules/.bin/babel-node ./node_modules/.bin/sequelize db:seed:undo:all",
+    "undo:seed": "./node_modules/.bin/babel-node ./node_modules/.bin/sequelize db:seed:undo:all",
     "seed": "./node_modules/.bin/babel-node ./node_modules/.bin/sequelize db:seed:all",
-    "undo-migration": "./node_modules/.bin/babel-node ./node_modules/.bin/sequelize db:migrate:undo:all",
+    "undo:migration": "./node_modules/.bin/babel-node ./node_modules/.bin/sequelize db:migrate:undo:all",
     "migrate": "./node_modules/.bin/babel-node ./node_modules/.bin/sequelize db:migrate"
   },
   "author": "Andela Simulations Programme",

src/test/integrationTests/userController.test.js

@@ -128,5 +128,19 @@ describe('Integration tests for the user controller', () => {
       expect(response.body.message)
         .to.equal('Invalid request. All fields are required');
     });
+
+    it('should return client error when user details is missing', async () => {
+      const userDetails = {
+        password: 'johndoe@wemail.com',
+      };
+      const response = await chai.request(app).post('/api/v1/auth/login')
+        .send(userDetails);
+      expect(response.status).to.deep.equal(400);
+      expect(response.body).to.have.property('success');
+      expect(response.body.success).to.equal(false);
+      expect(response.body).to.have.property('message');
+      expect(response.body.message)
+        .to.equal('Invalid request. All fields are required');
+    });
   });
 });

src/test/unitTests/middleware.test.js

@@ -8,7 +8,10 @@ const req = {
   query: {
     token: () => {}
   },
-  headers: { 'x-access-token': () => undefined }
+  body: {
+    token: () => {}
+  },
+  headers: { 'x-access-token': undefined }
 };
 const res = {};
 const next = () => {};
@@ -26,7 +29,7 @@ describe('Unit test for the Authorization utility function', () => {
     expect(req.decoded.message).to.equal('token found in query');
   });
   it('should check the request body for a token', async () => {
-    req.body = () => {}; req.query = () => undefined;
+    req.body.token = () => {}; req.query.token = undefined;
     stubbedMethod = sinon
       .stub(Authentication, 'verifyToken')
       .returns({ success: true, message: 'token found in body' });