feature(social Oauth):add social media login route #29

okikiola11 · 2019-08-22T17:05:22Z

What does this PR do?

add social Oauth login

Description of Task to be completed?

implement social media login route for Facebook and Google

How should this be manually tested?

Clone the repo and cd into the project directory
Run yarn install to install the project's dependency
Run yarn start to start the app

What are the relevant pivotal tracker stories?

#167727629

Screenshot

hound · 2019-08-22T17:05:27Z

src/routes/index.js

@@ -2,4 +2,4 @@ const router = require("express").Router();

 router.use("/api", require("./api"));

-module.exports = router;
+export default router;


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

A add a new line here.

src/routes/authRoutes.js

hound · 2019-08-22T17:05:27Z

src/config/passport.js

@@ -0,0 +1,17 @@
+import passport from "passport";


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

hound · 2019-08-22T17:05:27Z

src/config/keys.js

@@ -0,0 +1,8 @@
+import dotenv from 'dotenv';


Parsing error: 'import' and 'export' may appear only with 'sourceType: module'

src/utils/helpers.js

hound · 2019-08-26T02:13:30Z

src/utils/helpers.js

@@ -0,0 +1,7 @@
+class Helper {


Missing JSDoc comment require-jsdoc

hound · 2019-08-26T02:13:30Z

src/routes/v1/socialRoutes.js

+router.get('/facebook/redirect',
+  passport.authenticate('facebook', {
+    session: false
+  }), SocialController.socialLogin);


Expected a newline before ')' function-paren-newline

hound · 2019-08-26T02:13:30Z

src/routes/v1/socialRoutes.js

+  scope: ['profile']
+}));
+
+router.get('/facebook/redirect',


Expected a newline after '(' function-paren-newline

hound · 2019-08-26T02:13:30Z

src/routes/v1/socialRoutes.js

+router.get('/google/redirect',
+  passport.authenticate('google', {
+    session: false
+  }), SocialController.socialLogin);


Expected a newline before ')' function-paren-newline

hound · 2019-08-26T02:13:31Z

src/controllers/socialController.js

+        }
+      });
+    } catch (error) {
+      console.log(error.message);


Unexpected console statement no-console

hound · 2019-08-26T02:13:31Z

src/controllers/socialController.js

+    try {
+      const {
+        _json: user,
+        provider


'provider' is assigned a value but never used no-unused-vars

hound · 2019-08-26T02:13:32Z

src/controllers/socialController.js

+config();
+
+class SocialController {
+  static async socialLogin(req, res) {


Missing JSDoc comment require-jsdoc

hound · 2019-08-26T02:13:32Z

src/controllers/socialController.js

+
+config();
+
+class SocialController {


Missing JSDoc comment require-jsdoc

hound · 2019-08-26T02:13:32Z

src/controllers/socialController.js

+import jwt from 'jsonwebtoken';
+import {
+  config
+} from 'dotenv';


Unexpected line break before this closing brace object-curly-newline

hound · 2019-08-26T07:07:58Z

src/controllers/socialController.js

@@ -0,0 +1,57 @@
+import jwt from 'jsonwebtoken';
+import {


Unexpected line break after this opening brace object-curly-newline

I love the way you created a new file for this and for also following the naming convention. 👍

hound · 2019-08-26T07:07:58Z

src/config/passport.js

+      clientID: FACEBOOK_CLIENT_ID,
+      clientSecret: FACEBOOK_CLIENT_SECRET
+    }, passportCb)
+  );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T07:07:58Z

src/config/passport.js

+      clientSecret: GOOGLE_CLIENT_SECRET
+    }, passportCb)
+  );
+  passport.use(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-26T07:07:58Z

src/config/passport.js

+      clientID: GOOGLE_CLIENT_ID,
+      clientSecret: GOOGLE_CLIENT_SECRET
+    }, passportCb)
+  );


Unexpected newline before ')' function-paren-newline

hound · 2019-08-26T07:07:58Z

src/config/passport.js

+} = env;
+
+const setupPassport = () => {
+  passport.use(


Unexpected newline after '(' function-paren-newline

hound · 2019-08-26T07:07:58Z

src/config/passport.js

+import passport from 'passport';
+import {
+  Strategy as GoogleStrategy
+} from 'passport-google-oauth20';


Unexpected line break before this closing brace object-curly-newline

hound · 2019-08-26T07:07:58Z

src/config/passport.js

@@ -0,0 +1,44 @@
+import passport from 'passport';
+import {


Unexpected line break after this opening brace object-curly-newline

hound · 2019-08-27T16:09:19Z

src/controllers/socialController.js

+        first_name,
+        email
+      } = user;
+      const userData = await SocialController.findOrCreateUserByEmail(first_name, last_name, email);


Line 80 exceeds the maximum line length of 80 max-len

hound · 2019-08-27T16:09:20Z

src/controllers/socialController.js

+
+      const {
+        last_name,
+        first_name,


Identifier 'first_name' is not in camel case camelcase

hound · 2019-08-27T16:09:20Z

src/controllers/socialController.js

+      }
+
+      const {
+        last_name,


Identifier 'last_name' is not in camel case camelcase

hound · 2019-08-27T16:09:20Z

src/controllers/socialController.js

+        _raw,
+        _json: user
+      } = req.user;
+      console.log(user);


Unexpected console statement no-console

hound · 2019-08-27T16:09:20Z

src/controllers/socialController.js

+  static async facebookLogin(req, res) {
+    try {
+      const {
+        _raw,


'_raw' is assigned a value but never used no-unused-vars

hound · 2019-08-27T16:09:20Z

src/controllers/socialController.js

+    }
+  }
+
+  static async facebookLogin(req, res) {


Missing JSDoc comment require-jsdoc

hound · 2019-08-27T16:09:20Z

src/controllers/socialController.js

+        }
+      });
+    } catch (error) {
+      console.log(error.message);


Unexpected console statement no-console

hound · 2019-08-27T16:09:21Z

src/controllers/socialController.js

+          error: 'No email address is found for this user'
+        });
+      }
+      const userData = await SocialController.findOrCreateUserByEmail(user.firstName, user.lastName, user.email);


Line 39 exceeds the maximum line length of 80 max-len

Also, just login not to create a user.

hound · 2019-08-27T16:09:21Z

src/controllers/socialController.js

+    return userData;
+  }
+
+  static async googleLogin(req, res) {


Missing JSDoc comment require-jsdoc

please add a JSDOC. look at other controllers to see how we have been writing JSDOCs for controller

hound · 2019-08-27T16:09:21Z

src/config/passport.js

+      callbackURL: 'http://localhost:3000/api/v1/auth/facebook/redirect',
+      clientID: FACEBOOK_CLIENT_ID,
+      clientSecret: FACEBOOK_CLIENT_SECRET,
+      profileFields: ['id', 'email', 'gender', 'link', 'locale', 'name', 'timezone', 'updated_time', 'verified']


Line 34 exceeds the maximum line length of 80 max-len

Fix this hound error by doing

[ 'id', 'email', 'gender', 'link', 'locale', 'name', 'timezone', 'updated_time', 'verified' ];

Daymorelah · 2019-08-28T12:09:36Z

.sequelizerc

@@ -1,5 +1,7 @@
+require('@babel/register');


why are you importing babel register in here?

Daymorelah · 2019-08-28T12:09:54Z

.sequelizerc

 const path = require('path');

+


why did you add a new line here?.

Daymorelah · 2019-08-28T12:10:44Z

src/config/env-config.js

+  env
+} = process;
+
+export default env;


Why was this file created?. Is it necessary?

Daymorelah · 2019-08-28T12:11:57Z

src/config/passport.js

+  Strategy as GoogleStrategy
+} from 'passport-google-oauth20';
+import env from './env-config';
+import Helpers from '../utils/helpers';


This is not how we have been importing helpermethods in the codebase. Please import it correctly.

src/config/passport.js

Daymorelah · 2019-08-28T12:27:52Z

src/controllers/socialController.js

+          error: 'No email address is found for this user'
+        });
+      }
+      const userData = await SocialController.findOrCreateUserByEmail(user.firstName, user.lastName, user.email);


Also, just login not to create a user.

src/models/User.js

Daymorelah · 2019-08-28T12:30:17Z

src/routes/index.js

@@ -2,4 +2,4 @@ const router = require("express").Router();

 router.use("/api", require("./api"));

-module.exports = router;
+export default router;


A add a new line here.

src/routes/v1/index.js

src/routes/v1/socialRoutes.js

hound · 2019-08-29T11:29:05Z

src/utils/helpers.js

+ * @param {string} done - user profile
+ * @return {object} - user profile
+ */
+export const passportCb = (accessToken, requestToken, profile, done) => done(null, profile);


Line 9 exceeds the maximum line length of 90 max-len
Prefer default export import/prefer-default-export

hound · 2019-08-29T11:29:05Z

src/test/unitTests/socialController.test.js

@@ -0,0 +1,3 @@
+import sinon from 'sinon';
+import chai from 'chai';
+import passport from 'passport';


'passport' is defined but never used no-unused-vars

hound · 2019-08-29T11:29:06Z

src/test/unitTests/socialController.test.js

@@ -0,0 +1,3 @@
+import sinon from 'sinon';
+import chai from 'chai';


'chai' is defined but never used no-unused-vars

hound · 2019-08-29T11:29:06Z

src/test/unitTests/socialController.test.js

@@ -0,0 +1,3 @@
+import sinon from 'sinon';


'sinon' is defined but never used no-unused-vars

hound · 2019-08-29T11:29:06Z

src/test/unitTests/sendEmail.test.js

-import { SendEmail } from '../../utils';
+import {
+  SendEmail
+} from '../../utils';


Unexpected line break before this closing brace object-curly-newline

hound · 2019-08-29T11:29:07Z

src/routes/socialAuthRoute.js

+    scope: ['profile', 'email']
+  }));
+
+  app.get('/api/v1/auth/google/redirect',


Expected a newline after '(' function-paren-newline

hound · 2019-08-29T11:29:08Z

src/routes/requestRoute.js

@@ -9,4 +11,4 @@ const requestRoutes = app => {
    RequestController.bookATrip);
 };

-export default requestRoutes;
+export default requestRoutes;


Newline required at end of file but not found eol-last

hound · 2019-08-29T11:29:08Z

src/routes/requestRoute.js

-import { RequestController } from '../controllers';
+import {
+  RequestController
+} from '../controllers';


Unexpected line break before this closing brace object-curly-newline

hound · 2019-08-29T11:29:08Z

src/routes/requestRoute.js

@@ -1,4 +1,6 @@
-import { RequestController } from '../controllers';
+import {


Unexpected line break after this opening brace object-curly-newline

hound · 2019-08-29T11:29:08Z

src/models/User.js

-import { CryptData } from '../utils';
+import {
+  CryptData
+} from '../utils';


Unexpected line break before this closing brace object-curly-newline

hound · 2019-08-30T09:34:23Z

src/models/User.js

@@ -1,4 +1,6 @@
-import { CryptData } from '../utils';
+import {


Unexpected line break after this opening brace object-curly-newline

hound · 2019-08-30T09:34:23Z

src/test/unitTests/socialController.test.js

+import app from '../../index';
+import {
+  passportCb
+} from '../../utils/helpers';


Unexpected line break before this closing brace object-curly-newline

hound · 2019-08-30T09:34:23Z

src/test/unitTests/socialController.test.js

+import chaiHttp from 'chai-http';
+import passport from 'passport';
+import app from '../../index';
+import {


Unexpected line break after this opening brace object-curly-newline

hound · 2019-08-30T09:34:24Z

src/config/passport.js

+      callbackURL: 'http://localhost:3000/api/v1/auth/facebook/redirect',
+      clientID: FACEBOOK_CLIENT_ID,
+      clientSecret: FACEBOOK_CLIENT_SECRET,
+      profileFields: ['id', 'email', 'gender', 'link', 'locale', 'name', 'timezone', 'updated_time', 'verified']


Line 34 exceeds the maximum line length of 90 max-len

src/config/passport.js

src/seeders/01-demo-user.js

hound · 2019-08-30T09:34:26Z

src/controllers/socialController.js

+        value: userEmail
+      }] = emails;
+      if (!userEmail) {
+        return HelperMethods.clientError(res, 'No email address is found for this user', 400);


Line 91 exceeds the maximum line length of 90 max-len

hound · 2019-08-30T09:34:26Z

src/controllers/socialController.js

+  static async facebookLogin(req, res) {
+    try {
+      const {
+        _json: user,


'user' is assigned a value but never used no-unused-vars

hound · 2019-08-30T09:34:26Z

src/controllers/socialController.js

+        value: userEmail
+      }] = emails;
+      if (!userEmail) {
+        return HelperMethods.clientError(res, 'No email address is found for this user', 400);


Line 51 exceeds the maximum line length of 90 max-len

hound · 2019-08-30T09:34:26Z

src/controllers/socialController.js

+    // check if user exist
+    try {
+      const {
+        _json: user,


'user' is assigned a value but never used no-unused-vars

hound · 2019-08-30T09:43:41Z

src/controllers/socialController.js

+   * @memberof socialController
+   */
+
+  static async googleLogin(req, res) {


Missing JSDoc comment require-jsdoc

hound · 2019-08-30T09:43:41Z

src/controllers/socialController.js

+
+dotenv.config();
+
+class SocialController {


Missing JSDoc comment require-jsdoc

hound · 2019-08-30T13:25:24Z

src/test/integrationTests/userController.test.js

-import { UserController } from '../../controllers';
+import {
+  UserController
+} from '../../controllers';


Unexpected line break before this closing brace object-curly-newline

src/test/integrationTests/userController.test.js

hound · 2019-08-30T13:25:25Z

src/routes/userRoute.js

-import { UserController } from '../controllers';
+import {
+  UserController
+} from '../controllers';


Unexpected line break before this closing brace object-curly-newline

hound · 2019-08-30T13:25:25Z

src/routes/userRoute.js

@@ -1,4 +1,6 @@
-import { UserController } from '../controllers';
+import {


Unexpected line break after this opening brace object-curly-newline

src/seeders/01-demo-user.js

hound · 2019-08-30T13:25:26Z

src/seeders/01-demo-user.js

+      createdAt: new Date(),
+      updatedAt: new Date()
+    },
+    {


Expected indentation of 2 spaces but found 4 indent

hound · 2019-08-30T13:25:27Z

src/seeders/01-demo-user.js

+      password: await init(),
+      createdAt: new Date(),
+      updatedAt: new Date()
+    },


Expected indentation of 2 spaces but found 4 indent

hound · 2019-08-30T13:25:27Z

src/seeders/01-demo-user.js

+      username: 'user2',
+      password: await init(),
+      createdAt: new Date(),
+      updatedAt: new Date()


Expected indentation of 4 spaces but found 6 indent

src/seeders/01-demo-user.js

package.json

Daymorelah · 2019-09-01T10:39:22Z

package.json

@@ -68,4 +71,4 @@
    "nyc": "^14.1.1",
    "sinon": "^7.4.1"
  }
-}
+}


Add a new line here.

src/config/passport.js

hound · 2019-09-05T09:12:52Z

src/routes/index.js

 };

-export default routes;
+export default routes;


Newline required at end of file but not found eol-last

hound · 2019-09-05T09:12:52Z

src/controllers/socialController.js

+      if (!userData) {
+        return HelperMethods.clientError(res,
+          'You are not a registered user. Please, signup',
+          404);


Expected a newline before ')' function-paren-newline

hound · 2019-09-05T09:12:52Z

src/controllers/socialController.js

+      }
+      const userData = await SocialController.findByEmail(userEmail);
+      if (!userData) {
+        return HelperMethods.clientError(res,


Expected a newline after '(' function-paren-newline

hound · 2019-09-05T09:12:52Z

src/controllers/socialController.js

+      if (!userEmail) {
+        return HelperMethods.clientError(res,
+          'No email address is found for this user',
+          400);


Expected a newline before ')' function-paren-newline

hound · 2019-09-05T09:12:52Z

src/controllers/socialController.js

+    try {
+      const [{ value: userEmail }] = req.user.emails;
+      if (!userEmail) {
+        return HelperMethods.clientError(res,


Expected a newline after '(' function-paren-newline

hound · 2019-09-05T09:12:53Z

src/controllers/socialController.js

+    try {
+      const [{ value: userEmail }] = req.user.emails;
+      if (!userEmail) {
+        return HelperMethods.clientError(


Unexpected newline after '(' function-paren-newline

hound · 2019-09-05T09:12:53Z

src/config/passport.js

+        'name', 'timezone', 'updated_time', 'verified'
+      ],
+    }, passportCb)
+  );


Unexpected newline before ')' function-paren-newline

hound · 2019-09-05T09:12:53Z

src/config/passport.js

+      clientSecret: GOOGLE_CLIENT_SECRET
+    }, passportCb)
+  );
+  passport.use(


Unexpected newline after '(' function-paren-newline

hound · 2019-09-05T09:12:53Z

src/config/passport.js

+      clientID: GOOGLE_CLIENT_ID,
+      clientSecret: GOOGLE_CLIENT_SECRET
+    }, passportCb)
+  );


Unexpected newline before ')' function-paren-newline

hound · 2019-09-05T09:12:54Z

src/config/passport.js

+const passportCb = (accessToken, requestToken, profile, done) => done(null, profile);
+
+const setupPassport = () => {
+  passport.use(


Unexpected newline after '(' function-paren-newline

hound · 2019-09-05T13:19:28Z

src/config/passport.js

+ */
+export const passportCb = (accessToken, requestToken, profile, done) => done(
+  null, profile
+);


Unexpected newline before ')' function-paren-newline

hound · 2019-09-05T13:19:28Z

src/config/passport.js

+ * @param {string} done - user profile
+ * @return {object} - user profile
+ */
+export const passportCb = (accessToken, requestToken, profile, done) => done(


Unexpected newline after '(' function-paren-newline

hound bot reviewed Aug 22, 2019

View reviewed changes

okikiola11 added the W.I.P The PR is still being worked on label Aug 22, 2019

okikiola11 force-pushed the ft-soial-auth-#167727629 branch 2 times, most recently from eb31152 to 8bd5891 Compare August 26, 2019 02:13

hound bot reviewed Aug 26, 2019

View reviewed changes

okikiola11 added Ready-for-review The PR is ready to be reviewed by teammates and removed W.I.P The PR is still being worked on labels Aug 26, 2019

okikiola11 force-pushed the ft-soial-auth-#167727629 branch from 8bd5891 to 4e371e5 Compare August 26, 2019 07:07

hound bot reviewed Aug 26, 2019

View reviewed changes

okikiola11 force-pushed the ft-soial-auth-#167727629 branch from 4e371e5 to f96514e Compare August 27, 2019 16:09

hound bot reviewed Aug 27, 2019

View reviewed changes

Daymorelah suggested changes Aug 28, 2019

View reviewed changes

okikiola11 force-pushed the ft-soial-auth-#167727629 branch from f96514e to afa891b Compare August 29, 2019 11:28

hound bot reviewed Aug 29, 2019

View reviewed changes

okikiola11 force-pushed the ft-soial-auth-#167727629 branch from afa891b to 339d986 Compare August 30, 2019 09:34

hound bot reviewed Aug 30, 2019

View reviewed changes

okikiola11 force-pushed the ft-soial-auth-#167727629 branch from 339d986 to 39e43bd Compare August 30, 2019 09:43

hound bot reviewed Aug 30, 2019

View reviewed changes

okikiola11 force-pushed the ft-soial-auth-#167727629 branch from 39e43bd to 7c55c71 Compare August 30, 2019 13:25

hound bot reviewed Aug 30, 2019

View reviewed changes

Daymorelah suggested changes Sep 1, 2019

View reviewed changes

okikiola11 force-pushed the ft-soial-auth-#167727629 branch 9 times, most recently from 732d57b to 9a4f9d7 Compare September 2, 2019 13:44

okikiola11 requested a review from Daymorelah September 2, 2019 14:27

Daymorelah force-pushed the ft-soial-auth-#167727629 branch from 9a4f9d7 to b2e0742 Compare September 5, 2019 09:12

hound bot reviewed Sep 5, 2019

View reviewed changes

feature(social Oauth):add social media login route

f59c47c

Daymorelah force-pushed the ft-soial-auth-#167727629 branch from b2e0742 to f59c47c Compare September 5, 2019 13:19

hound bot reviewed Sep 5, 2019

View reviewed changes

Daymorelah merged commit d6a0ceb into develop Sep 5, 2019

		@@ -0,0 +1,3 @@
		import sinon from 'sinon';
		import chai from 'chai';

		@@ -1,4 +1,6 @@
		import { RequestController } from '../controllers';
		import {

		@@ -1,4 +1,6 @@
		import { CryptData } from '../utils';
		import {

		@@ -1,4 +1,6 @@
		import { UserController } from '../controllers';
		import {


		config();

		class SocialController {

feature(social Oauth):add social media login route #29

feature(social Oauth):add social media login route #29

Conversation

okikiola11 commented Aug 22, 2019 • edited by Daymorelah Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

What are the relevant pivotal tracker stories?

Screenshot

hound bot Aug 22, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hound bot Aug 22, 2019

Choose a reason for hiding this comment

hound bot Aug 22, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 26, 2019

Choose a reason for hiding this comment

hound bot Aug 27, 2019

Choose a reason for hiding this comment

hound bot Aug 27, 2019

Choose a reason for hiding this comment

hound bot Aug 27, 2019

Choose a reason for hiding this comment

hound bot Aug 27, 2019

Choose a reason for hiding this comment

hound bot Aug 27, 2019

Choose a reason for hiding this comment

hound bot Aug 27, 2019

Choose a reason for hiding this comment

hound bot Aug 27, 2019

Choose a reason for hiding this comment

hound bot Aug 27, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hound bot Aug 27, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hound bot Aug 27, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hound bot Aug 29, 2019

Choose a reason for hiding this comment

okikiola11 commented Aug 22, 2019 •

edited by Daymorelah

Loading