#167727662-Re-Confirm-Travel-Requests #47

gmemmy · 2019-09-03T14:58:24Z

What does this PR do

It implements a confirmation feature for a line manager to confirm an approved travel request.

Description of Task to be completed?

Create a feature that allows a line manager to confirm the request of his/her direct report.

How should this be manually tested?

Clone the repo and cd into the project directory
Run yarn install to install the project's dependency
Run yarn start to start the app
Access the route for approving a request and fill in the required fields.

What are the relevant pivotal tracker stories?

#167727662

Any background context you want to add?

src/utils/helperMethod.js

src/controllers/RequestController.js

src/test/integrationTests/requestController.test.js

src/utils/helperMethod.js

Daymorelah · 2019-09-04T03:36:53Z

Please, re-implement this feature. create a separate route handler for this feature in implement the logic for this feature in the route handler you will create.

src/validation/index.js

src/controllers/RequestController.js

src/models/Request.js

src/migrations/03-create-requests.js

* feature(request):add multi-city request route Create feature to confirm approved travel requests * feature(request):add multi-city request route

src/controllers/RequestController.js

src/test/unitTests/sendEmail.test.js

src/test/unitTests/requestController.test.js

src/test/integrationTests/userController.test.js

src/routes/socialAuthRoute.js

src/routes/index.js

src/models/User.js

src/index.js

src/controllers/RequestController.js

…ub.com/andela/rogue-backend into ft-reconfirm-travel-requests-167727662

hound · 2019-09-05T14:27:00Z

src/controllers/RequestController.js

+          'Could not confirm the request. Please try again', 400);
+      }
+      return HelperMethods.clientError(res,
+        'The request you are trying to confirm cannot be found', 404);


Expected a newline before ')' function-paren-newline

hound · 2019-09-05T14:27:00Z

src/controllers/RequestController.js

+      if (approvedRequest) {
+        if (approvedRequest.status === 'confirmed') {
+          return HelperMethods.clientError(res,
+            'This request has already been confirmed', 404);


Expected a newline before ')' function-paren-newline

hound · 2019-09-05T14:27:00Z

src/controllers/RequestController.js

+      });
+      if (approvedRequest) {
+        if (approvedRequest.status === 'confirmed') {
+          return HelperMethods.clientError(res,


Expected a newline after '(' function-paren-newline

gmemmy added the W.I.P The PR is still being worked on label Sep 3, 2019

hound bot reviewed Sep 3, 2019

View reviewed changes

gmemmy force-pushed the ft-reconfirm-travel-requests-167727662 branch 2 times, most recently from b3abbfb to 04bd48e Compare September 3, 2019 16:33

hound bot reviewed Sep 3, 2019

View reviewed changes

src/test/integrationTests/requestController.test.js Outdated Show resolved Hide resolved

src/test/integrationTests/requestController.test.js Outdated Show resolved Hide resolved

gmemmy force-pushed the ft-reconfirm-travel-requests-167727662 branch from 04bd48e to 257326d Compare September 3, 2019 16:35

gmemmy added Ready-for-review The PR is ready to be reviewed by teammates and removed W.I.P The PR is still being worked on labels Sep 3, 2019

gmemmy force-pushed the ft-reconfirm-travel-requests-167727662 branch 4 times, most recently from 79ed639 to e3ea728 Compare September 3, 2019 18:46

hound bot reviewed Sep 3, 2019

View reviewed changes

src/utils/helperMethod.js Outdated Show resolved Hide resolved

src/utils/helperMethod.js Outdated Show resolved Hide resolved

gmemmy force-pushed the ft-reconfirm-travel-requests-167727662 branch from e3ea728 to 77a0ec7 Compare September 3, 2019 18:55

gmemmy force-pushed the ft-reconfirm-travel-requests-167727662 branch from 6c77078 to 6c80f92 Compare September 4, 2019 09:32

hound bot reviewed Sep 4, 2019

View reviewed changes

gmemmy force-pushed the ft-reconfirm-travel-requests-167727662 branch 2 times, most recently from 2caf5eb to d5e3505 Compare September 4, 2019 10:32

hound bot reviewed Sep 5, 2019

View reviewed changes

src/models/Request.js Outdated Show resolved Hide resolved

src/migrations/03-create-requests.js Outdated Show resolved Hide resolved

gmemmy added the W.I.P The PR is still being worked on label Sep 5, 2019

gmemmy force-pushed the ft-reconfirm-travel-requests-167727662 branch 2 times, most recently from 7c8c877 to 0ecc161 Compare September 5, 2019 07:45

gmemmy removed the W.I.P The PR is still being worked on label Sep 5, 2019

Create feature to confirm approved travel requests

189c013

* feature(request):add multi-city request route Create feature to confirm approved travel requests * feature(request):add multi-city request route

gmemmy force-pushed the ft-reconfirm-travel-requests-167727662 branch from 0ecc161 to 189c013 Compare September 5, 2019 12:31

hound bot reviewed Sep 5, 2019

View reviewed changes

src/controllers/RequestController.js Outdated Show resolved Hide resolved

hound bot reviewed Sep 5, 2019

View reviewed changes

Daymorelah force-pushed the ft-reconfirm-travel-requests-167727662 branch from 92a1e31 to 4920eb6 Compare September 5, 2019 14:12

hound bot reviewed Sep 5, 2019

View reviewed changes

src/controllers/RequestController.js Show resolved Hide resolved

src/controllers/RequestController.js Outdated Show resolved Hide resolved

src/controllers/RequestController.js Outdated Show resolved Hide resolved

Merge branch 'ft-reconfirm-travel-requests-167727662' of https://gith…

eefce86

…ub.com/andela/rogue-backend into ft-reconfirm-travel-requests-167727662

Daymorelah force-pushed the ft-reconfirm-travel-requests-167727662 branch from 4920eb6 to eefce86 Compare September 5, 2019 14:26

hound bot reviewed Sep 5, 2019

View reviewed changes

Daymorelah merged commit 26b7880 into develop Sep 5, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#167727662-Re-Confirm-Travel-Requests #47

#167727662-Re-Confirm-Travel-Requests #47

gmemmy commented Sep 3, 2019 •

edited

Loading

Daymorelah commented Sep 4, 2019

hound bot Sep 5, 2019

hound bot Sep 5, 2019

hound bot Sep 5, 2019

#167727662-Re-Confirm-Travel-Requests #47

#167727662-Re-Confirm-Travel-Requests #47

Conversation

gmemmy commented Sep 3, 2019 • edited Loading

What does this PR do

Description of Task to be completed?

How should this be manually tested?

What are the relevant pivotal tracker stories?

Any background context you want to add?

Daymorelah commented Sep 4, 2019

hound bot Sep 5, 2019

Choose a reason for hiding this comment

hound bot Sep 5, 2019

Choose a reason for hiding this comment

hound bot Sep 5, 2019

Choose a reason for hiding this comment

gmemmy commented Sep 3, 2019 •

edited

Loading