[166240824] Enable Social Login via Google and Facebook #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ramadhan0
force-pushed
the
ft-SocialLogin-#166240824
branch
5 times, most recently
from
012a090
to
b73c289
Compare
Ramadhan0
force-pushed
the
ft-SocialLogin-#166240824
branch
20 times, most recently
from
d6d2a89
to
78f0605
Compare
Ramadhan0
force-pushed
the
ft-SocialLogin-#166240824
branch
2 times, most recently
from
b28b1b9
to
5dba265
Compare
Ramadhan0
force-pushed
the
ft-SocialLogin-#166240824
branch
from
5dba265
to
83334cd
Compare
alainburindi
suggested changes
Jun 24, 2019
src/api/controllers/socialAuth.js
Outdated
| provider: req.user.provider, | ||
| uniqueId: req.user.id | ||
| }); | ||
| const token = generateToken({ username: req.user.displayName, id: req.user.id }, |
There was a problem hiding this comment.
here it is nor the id from the req.user but from the table's dataValues
src/api/controllers/socialAuth.js
Outdated
| provider: req.user.provider, | ||
| uniqueId: req.user.id | ||
| }); | ||
| const token = generateToken({ username: req.user.displayName, id: req.user.id }, |
| @@ -0,0 +1,39 @@ | |||
| /** | |||
There was a problem hiding this comment.
you still have hound issue
Ramadhan0
force-pushed
the
ft-SocialLogin-#166240824
branch
from
09e6765
to
e5354dd
Compare
|
Please put the |
|
Please can you refer to @MCFrank16 or @truestbyheart PR to see how they have written this part. |
Ramadhan0
force-pushed
the
ft-SocialLogin-#166240824
branch
3 times, most recently
from
e19db4d
to
d09a33f
Compare
package.json
Outdated
| @@ -5,6 +5,7 @@ | |||
| "main": "index.js", | |||
| "scripts": { | |||
| "start": "babel-node src/index.js", | |||
| "setup": "NODE_ENV=test npm run migrate:undo && NODE_ENV=test npm run migrate && NODE_ENV=test npm run seed", | |||
There was a problem hiding this comment.
@Ramadhan0 why do you need this?
| @@ -68,5 +67,6 @@ export default { | |||
| type: Sequelize.DATE | |||
| } | |||
| }), | |||
| // eslint-disable-next-line no-unused-vars | |||
There was a problem hiding this comment.
@Ramadhan0 why are you disabling this eslint rule?
| @@ -7,8 +7,7 @@ export default { | |||
| type: Sequelize.INTEGER | |||
| }, | |||
| username: { | |||
| type: Sequelize.STRING, | |||
| unique: true | |||
| type: Sequelize.STRING | |||
There was a problem hiding this comment.
@Ramadhan0 username should be unique.
| @@ -0,0 +1,51 @@ | |||
| export default { | |||
There was a problem hiding this comment.
@Ramadhan0 why do you have this file in your work?
src/api/models/test-articl.js
Outdated
| @@ -0,0 +1,10 @@ | |||
| 'use strict'; | |||
There was a problem hiding this comment.
@Ramadhan0 same with this file. why is it here?
Ramadhan0
force-pushed
the
ft-SocialLogin-#166240824
branch
from
d09a33f
to
4deeaf5
Compare
Ramadhan0
force-pushed
the
ft-SocialLogin-#166240824
branch
from
4deeaf5
to
fc75178
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Signup and Login user via google, facebook and twitter
Description of Task to be completed?
Have this point working
/api/auth/facebook: this is the endpoint, a user will hit whenever he/she wants to log in or signup using facebook./api/auth/google: this is the endpoint, a user will hit whenever he/she wants to log in or signup using google./api/auth/twitter: this is the endpoint, a user will hit whenever he/she wants to log in or signup using twitter.How should this be manually tested?
Clone the repo by typing
git clone https://github.com/andela/savage_rangers-ahinto the terminalRun the server with this command
npm run devTest it with your browser by typing:
localhost:3001/api/users/googlelocalhost:3001/api/users/facebooklocalhost:3001/api/users/twitterWhat are the relevant pivotal tracker stories?
166240824
localhost:3001/api/users/googlelocalhost:3001/api/users/facebooklocalhost:3001/api/users/twitter