#167224203 get highlighted text #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainburindi
force-pushed
the
ft-get-highlight-167224203
branch
2 times, most recently
from
3d5896c
to
54ab1b9
Compare
truestbyheart
suggested changes
Jul 11, 2019
alainburindi
force-pushed
the
ft-get-highlight-167224203
branch
2 times, most recently
from
f6679c8
to
7f5939c
Compare
truestbyheart
approved these changes
Jul 15, 2019
Ramadhan0
approved these changes
Jul 16, 2019
| @@ -63,6 +63,9 @@ articleRouter.post('/:slug/highlight', | |||
| validateInputs('highlight', highlightFields), | |||
| articleController.highlight); | |||
|
|
|||
| articleRouter.get('/:slug/highlight', checkArticle.getArticle, articleController.getHighlight); | |||
|
|
|||
There was a problem hiding this comment.
please remove these empty lines @alainburindi
alainburindi
force-pushed
the
ft-get-highlight-167224203
branch
from
7f5939c
to
37207f4
Compare
| @@ -49,5 +49,6 @@ export default { | |||
| parentCommentId: 'You can not reply to a reply', | |||
| notCommentOwner: 'You must be the owner of the comment in order to proceed', | |||
| noBookmark: 'You have no bookmarks', | |||
| noSlug: 'There is no article with the slug provided' | |||
| noSlug: 'There is no article with the slug provided', | |||
| noHighlight: 'No highlited text for this article', | |||
There was a problem hiding this comment.
@alainburindi it's highlighted not highlited
This mistake is happening across several files so please correct in other places, as well.
MemunaHaruna
approved these changes
Jul 16, 2019
alainburindi
force-pushed
the
ft-get-highlight-167224203
branch
from
37207f4
to
5d4e312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Have the
get highlighted textworkingDescription of Task to be completed?
Have the following endpoints working
/api/articles/:slug/highlight: highlight a textHow should this be manually tested?
npm installnpm run devWhat are the relevant pivotal tracker stories?
#167224203