#168373102 Fix rating stats and readtime estimation #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainburindi
approved these changes
Sep 9, 2019
nkpremices
changed the title
nkpremices
changed the title
nkpremices
force-pushed
the
bg-readtime-ratings-stats-fix-168373102
branch
from
66d6ede
to
2bef8a4
Compare
nkpremices
changed the title
nkpremices
force-pushed
the
bg-readtime-ratings-stats-fix-168373102
branch
from
2bef8a4
to
55c0f3d
Compare
Ramadhan0
approved these changes
Sep 10, 2019
| @@ -27,6 +29,26 @@ export default (data) => { | |||
| percentage: percentages[data.indexOf(element)] | |||
| })); | |||
|
|
|||
| if (data.length < MAX_DATA_LENGTH) { | |||
There was a problem hiding this comment.
@nkpremices a comment to describe what you're doing here would be helpful.
There was a problem hiding this comment.
Lemme do that @MemunaHaruna
| @@ -1,4 +1,4 @@ | |||
| import chai from 'chai'; | |||
| import chai, { expect } from 'chai'; | |||
There was a problem hiding this comment.
@nkpremices can you add a test for the read time estimation fix?
There was a problem hiding this comment.
I don't know how I can add a test for that as I'm just rounding up @MCFrank16
Give me an idea please
There was a problem hiding this comment.
But I'm going to try
nkpremices
force-pushed
the
bg-readtime-ratings-stats-fix-168373102
branch
from
55c0f3d
to
f4fa393
Compare
MemunaHaruna
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
readtimealways rounded up