Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#167727733 Return trip request #25

Merged
merged 1 commit into from
Aug 26, 2019
Merged

Conversation

komsic
Copy link
Collaborator

@komsic komsic commented Aug 25, 2019

What does this PR do?

Adds endpoint to make a return trip request

Description

  • modify requests model and migration files to include returnDate
  • modify request schema to update validation
  • modify request trip controller to include return date

How can this be manually tested

  • Clone the repo
  • Install dependencies, setup database and run npm run start: dev
  • Make a post request to api/v1/requests and pass in the values to make a return trip request

Relevant Pivotal tracker stories

@codeclimate
Copy link

codeclimate bot commented Aug 25, 2019

Code Climate has analyzed commit 4c0b0b9 and detected 0 issues on this pull request.

View more on Code Climate.

    - modify requests model and migration files to include returnDate
    - modify request schema to update validation
    - modify request trip controller to include return date
    [Finishes #167727733]
@komsic komsic force-pushed the ft-return-trip-request-167727733 branch from 63d5000 to 4c0b0b9 Compare August 26, 2019 12:21
Copy link
Collaborator

@dinorhythms dinorhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tobslob tobslob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tejiri4 tejiri4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tejiri4 tejiri4 merged commit 5a38c66 into develop Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants