Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#168429357 get a specific request #72

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

kola-1
Copy link
Collaborator

@kola-1 kola-1 commented Sep 16, 2019

What this PR does

This PR will let a manager accept a trip request

Tasks completed

  • add - add a controller to get a specific request

How this can be manually tested

  • Clone this branch
  • Change directory into it
  • Run npm install in your terminal to install all the dependencies
  • Add all the environment variables as specified in the .env.config file
  • Run npm run seed in your terminal to seed the database
  • Run npm run start:dev in your terminal to start the development server
  • Test with postman or go to this URL to test with swagger http://localhost:3000/api/v1/docs
  • Sign in as a user using this details email: brucewayne@gmail.com, password: brucewayne to test the request endpoint as a USER
  • Sign in as a user using this details email: linemanager@gmail.com, password: Password to test the request endpoint as a LINE MANAGER
  • Sign in as a user using this details email: jammy@gmail.com, password: jammy11167 to test the request endpoint as a SUPER ADMIN
  • Send a get request with to localhost:3000/api/v1/requests/0fcda9b7-e17f-4162-88ed-ded031063e53 to get that specific request detail

What are the relevant pivotal tracker stories?

#168429357

@kola-1 kola-1 added Finished completed task Review me labels Sep 16, 2019
@tejiri4 tejiri4 temporarily deployed to storm-backend-pr-72 September 16, 2019 17:31 Inactive
]);
};

const searchRequestRoute = (router) => {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar blocks of code found in 2 locations. Consider refactoring.

@codeclimate
Copy link

codeclimate bot commented Sep 16, 2019

Code Climate has analyzed commit 435fe71 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 95.2% (90% is the threshold).

This pull request will bring the total coverage in the repository to 95.7% (0.0% change).

View more on Code Climate.

@kola-1 kola-1 force-pushed the ft-get-particular-request-168429357 branch from 15fc31f to b66cb6b Compare September 16, 2019 17:55
@kola-1 kola-1 temporarily deployed to storm-backend-pr-72 September 16, 2019 17:55 Inactive
Copy link
Collaborator

@ladaposamuel ladaposamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

- add getSpecificRequest controller

[Finishes #168429357]
@tejiri4
Copy link
Contributor

tejiri4 commented Sep 17, 2019

Include the user table model in ur response body

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants