Ch fix reading stats #104
Merged
Ch fix reading stats #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 20, 2019
| updatedAt: singleStat.updatedAt | ||
| }; | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
| @@ -483,7 +484,22 @@ class User { | |||
| if (!stats || stats.length === 0) { | |||
| return helper.jsonResponse(res, 404, { message: 'No article read' }); | |||
| } | |||
| return helper.jsonResponse(res, 200, { stats, statsCount: stats.length }); | |||
| const allStats = await Promise.all( | |||
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
jnkindi
force-pushed
the
ch-reading-stats-fix-response
branch
from
4757a7b
to
656378b
Compare
houndci-bot
reviewed
Jun 20, 2019
| } | ||
| } | ||
| }); | ||
| return helper.jsonResponse(res, 200, { statsArticles: allStats, thisWeekRead, thisMonthRead }); |
There was a problem hiding this comment.
Line 524 exceeds the maximum line length of 100 max-len
| updatedAt: singleStat.updatedAt | ||
| }; | ||
| }) | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
| @@ -483,7 +485,43 @@ class User { | |||
| if (!stats || stats.length === 0) { | |||
| return helper.jsonResponse(res, 404, { message: 'No article read' }); | |||
| } | |||
| return helper.jsonResponse(res, 200, { stats, statsCount: stats.length }); | |||
| const allStats = await Promise.all( | |||
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
mystere10
approved these changes
Jun 21, 2019
mwibutsa
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?