Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#164489784 Feature login signup with email #16

Merged
merged 13 commits into from
Apr 10, 2019
Merged

#164489784 Feature login signup with email #16

merged 13 commits into from
Apr 10, 2019

Conversation

mwibutsa
Copy link
Contributor

@mwibutsa mwibutsa commented Apr 4, 2019

What does this PR do?

  • this PR adds sign up and log in with email functionality

Description of Task to be completed?

  • write tests for sign up feature
  • write tests for helpers
  • write tests for login
  • create a signup controller and route
  • create a login controller and route

How should this be manually tested?

  • to test sign up use postman to post to /api/users/
  • to test login use postman to post to /api/users/login

What are the relevant pivotal tracker stories?

@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 4, 2019 11:01 Inactive
houndci-bot
houndci-bot reviewed Apr 4, 2019
View reviewed changes
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
controllers/user.js Outdated Show resolved Hide resolved
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from a18594b to 7a37dce Compare April 4, 2019 11:50
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 4, 2019 11:50 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 7a37dce to f2f7f8c Compare April 4, 2019 11:58
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 4, 2019 11:58 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from f2f7f8c to 03eea90 Compare April 4, 2019 12:00
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 4, 2019 12:01 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 03eea90 to 9db03cf Compare April 8, 2019 11:58
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 8, 2019 11:58 Inactive
houndci-bot
houndci-bot reviewed Apr 8, 2019
View reviewed changes
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 9db03cf to 8e40f11 Compare April 8, 2019 12:26
houndci-bot
houndci-bot reviewed Apr 8, 2019
View reviewed changes
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
test/user.js Outdated Show resolved Hide resolved
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 8, 2019 12:26 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 8e40f11 to 54fc8b2 Compare April 8, 2019 12:30
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 4f70221 to 041b37f Compare April 9, 2019 08:33
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 9, 2019 08:33 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 041b37f to 6a96540 Compare April 9, 2019 09:08
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 9, 2019 09:08 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 6a96540 to db44803 Compare April 9, 2019 09:10
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 9, 2019 09:10 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from db44803 to 09d08fa Compare April 9, 2019 09:11
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 9, 2019 09:11 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 09d08fa to 5bee6d2 Compare April 10, 2019 06:23
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 10, 2019 06:23 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 5bee6d2 to 770abea Compare April 10, 2019 06:23
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 10, 2019 06:23 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 770abea to a0d97bb Compare April 10, 2019 09:06
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 10, 2019 09:06 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from a0d97bb to b18095f Compare April 10, 2019 09:10
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 10, 2019 09:10 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from b18095f to 2d6ecd7 Compare April 10, 2019 09:17
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 10, 2019 09:17 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 2d6ecd7 to 2354494 Compare April 10, 2019 09:22
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 10, 2019 09:22 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 2354494 to 86e3924 Compare April 10, 2019 09:56
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 10, 2019 09:56 Inactive
houndci-bot
houndci-bot reviewed Apr 10, 2019
View reviewed changes
test/user.js Show resolved Hide resolved
test/user.js Show resolved Hide resolved
test/user.js Show resolved Hide resolved
test/user.js Show resolved Hide resolved
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 86e3924 to 8983f07 Compare April 10, 2019 10:03
@Inclet Inclet temporarily deployed to strikers-ah-backend-stag-pr-16 April 10, 2019 10:03 Inactive
@mwibutsa mwibutsa force-pushed the ft-login-signup-with-email-164489784 branch from 8983f07 to b9bde3d Compare April 10, 2019 14:15
@cyrielo cyrielo merged commit 32476d7 into develop Apr 10, 2019
@cyrielo cyrielo deleted the ft-login-signup-with-email-164489784 branch April 10, 2019 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@frankhn frankhn frankhn approved these changes

@cyrielo cyrielo Awaiting requested review from cyrielo

@mystere10 mystere10 Awaiting requested review from mystere10

@jnkindi jnkindi Awaiting requested review from jnkindi

@Inclet Inclet Awaiting requested review from Inclet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mwibutsa @houndci-bot @frankhn @cyrielo @Inclet