#164489784 Integrate login with Twitter and GitHub #20

jnkindi · 2019-04-09T17:32:41Z

What does this PR do?

Integrated Login and signup with Twitter and GitHub

Description of Task to be completed?

The user is able to sign up / login using their usual twitter and GitHub account.

How should this be manually tested?

it can be tested by running {{URL}}/api/auth/twitter in the browser for twitter
it can also be tested by running {{URL}}/api/auth/github in the browser for twitter

Any background context you want to provide?

None

What are the relevant pivotal tracker stories?

164489784

Screenshots (if appropriate)

Questions:

None

houndci-bot · 2019-04-09T17:33:33Z

middlewares/passportStrategy/twitter.js

+  GetSocialTwitter(
+    token, tokenSecret, profile, done
+  );
+});


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-04-09T17:33:33Z

middlewares/passportStrategy/twitter.js

+async (token, tokenSecret, profile, done) => {
+  GetSocialTwitter(
+    token, tokenSecret, profile, done
+  );


Unexpected newline before ')' function-paren-newline

houndci-bot · 2019-04-09T17:33:33Z

middlewares/passportStrategy/twitter.js

+  callbackURL: process.env.TWITTER_CALLBACK,
+},
+async (token, tokenSecret, profile, done) => {
+  GetSocialTwitter(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2019-04-09T17:33:33Z

middlewares/passportStrategy/twitter.js

+ * @author Jacques Nyilinkindi
+ * @returns Twitter strategy
+ */
+const Twitter = new TwitterStrategy({


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-04-09T18:26:48Z

middlewares/passportStrategy/github.js

+  GetSocialGithub(
+    accessToken, refreshToken, profile, done
+  );
+});


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-04-09T18:26:48Z

middlewares/passportStrategy/github.js

+async (accessToken, refreshToken, profile, done) => {
+  GetSocialGithub(
+    accessToken, refreshToken, profile, done
+  );


Unexpected newline before ')' function-paren-newline

houndci-bot · 2019-04-09T18:26:48Z

middlewares/passportStrategy/github.js

+  callbackURL: process.env.GITHUB_CALLBACK
+},
+async (accessToken, refreshToken, profile, done) => {
+  GetSocialGithub(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2019-04-09T18:26:48Z

middlewares/passportStrategy/github.js

+ * @author Jacques Nyilinkindi
+ * @returns Github strategy
+ */
+const Github = new GithubStrategy({


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-04-09T18:26:49Z

middlewares/callbackHandler.js

+ * @returns { Object } user
+ */
+const GetSocialGithub = async (accessToken, refreshToken, profile, done) => {
+  console.log(profile);


Unexpected console statement no-console

houndci-bot · 2019-04-09T18:43:09Z

middlewares/passportStrategy/twitter.js

+  async (token, tokenSecret, profile, done) => {
+    GetSocialTwitter(
+      token, tokenSecret, profile, done
+    );


Unexpected newline before ')' function-paren-newline

houndci-bot · 2019-04-09T18:43:09Z

middlewares/passportStrategy/twitter.js

+    callbackURL: process.env.TWITTER_CALLBACK,
+  },
+  async (token, tokenSecret, profile, done) => {
+    GetSocialTwitter(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2019-04-09T18:43:09Z

middlewares/passportStrategy/github.js

+  async (accessToken, refreshToken, profile, done) => {
+    GetSocialGithub(
+      accessToken, refreshToken, profile, done
+    );


Unexpected newline before ')' function-paren-newline

houndci-bot · 2019-04-09T18:43:10Z

middlewares/passportStrategy/github.js

+    callbackURL: process.env.GITHUB_CALLBACK
+  },
+  async (accessToken, refreshToken, profile, done) => {
+    GetSocialGithub(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2019-04-16T09:41:31Z

index.js

+
+
+app.use('/api/articles', articleRoutes);
+app.use('/api/users', user);


'user' is not defined no-undef

Inclet temporarily deployed to strikers-ah-backend-stag-pr-20 April 9, 2019 17:32 Inactive

houndci-bot reviewed Apr 9, 2019

View reviewed changes

jnkindi force-pushed the ft-login-with-twitter-and-github-164489784 branch from 892ad58 to e2ecaee Compare April 9, 2019 17:43

Inclet temporarily deployed to strikers-ah-backend-stag-pr-20 April 9, 2019 17:43 Inactive

Inclet temporarily deployed to strikers-ah-backend-stag-pr-20 April 9, 2019 18:22 Inactive

houndci-bot reviewed Apr 9, 2019

View reviewed changes

jnkindi force-pushed the ft-login-with-twitter-and-github-164489784 branch from e5976b1 to 9cf09ac Compare April 9, 2019 18:30

Inclet temporarily deployed to strikers-ah-backend-stag-pr-20 April 9, 2019 18:30 Inactive

houndci-bot reviewed Apr 9, 2019

View reviewed changes

jnkindi force-pushed the ft-login-with-twitter-and-github-164489784 branch from 9cf09ac to d5e3853 Compare April 9, 2019 18:52

Inclet temporarily deployed to strikers-ah-backend-stag-pr-20 April 9, 2019 18:52 Inactive

jnkindi changed the title ~~#164489784 Integrate login with twitter and GitHub~~ #164489784 Integrate login with Twitter and GitHub Apr 9, 2019

jnkindi force-pushed the ft-login-with-twitter-and-github-164489784 branch from d5e3853 to d061792 Compare April 9, 2019 18:57

Inclet temporarily deployed to strikers-ah-backend-stag-pr-20 April 9, 2019 18:57 Inactive

Inclet temporarily deployed to strikers-ah-backend-stag-pr-20 April 10, 2019 08:58 Inactive

Inclet temporarily deployed to strikers-ah-backend-stag-pr-20 April 10, 2019 16:34 Inactive

jnkindi added 7 commits April 12, 2019 12:44

Ft 164489784 login with twitter

d939476

Ft 164489784 Added tests

3ac3d75

Ft 164489784 Implemented login with github

60ff2b3

Ft 164489784 Implemented faker data in test

f5fc59a

Moved usershelper to helpers from middlewares

d9b5c5f

FT 164489784 Removed duplicate in env variables

1af99af

Updated tests due to conflicts from rebase

b4a69f2

jnkindi force-pushed the ft-login-with-twitter-and-github-164489784 branch from 7e3293b to b4a69f2 Compare April 12, 2019 12:42

Inclet temporarily deployed to strikers-ah-backend-stag-pr-20 April 12, 2019 12:43 Inactive

jnkindi added 2 commits April 12, 2019 15:31

Removes helpers/schema which is no longer used

0d13a8e

Change in routes of authentication

8aaad09

Inclet temporarily deployed to strikers-ah-backend-stag-pr-20 April 12, 2019 16:02 Inactive

Updated social routes for returning tokens

c30abbb

jnkindi force-pushed the ft-login-with-twitter-and-github-164489784 branch from df86222 to c30abbb Compare April 12, 2019 16:12

Inclet deployed to strikers-ah-backend-stag-pr-20 April 12, 2019 16:12 View deployment

Merge branch 'develop' into ft-login-with-twitter-and-github-164489784

258f81e

houndci-bot reviewed Apr 16, 2019

View reviewed changes

index.js

app.use('/api/articles', articleRoutes);

app.use('/api/users', user);

Copy link

houndci-bot Apr 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'user' is not defined no-undef

Inclet requested a deployment to strikers-ah-backend-stag-pr-20 April 16, 2019 09:41 Abandoned

cyrielo merged commit 779429f into develop Apr 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#164489784 Integrate login with Twitter and GitHub #20

#164489784 Integrate login with Twitter and GitHub #20

jnkindi commented Apr 9, 2019 •

edited

Loading

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 9, 2019

houndci-bot Apr 16, 2019



		app.use('/api/articles', articleRoutes);
		app.use('/api/users', user);

#164489784 Integrate login with Twitter and GitHub #20

#164489784 Integrate login with Twitter and GitHub #20

Conversation

jnkindi commented Apr 9, 2019 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

164489784

Screenshots (if appropriate)

Questions:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jnkindi commented Apr 9, 2019 •

edited

Loading