Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#160928262 Test files in Home module #16

Merged
merged 1 commit into from
Oct 15, 2018
Merged

#160928262 Test files in Home module #16

merged 1 commit into from
Oct 15, 2018

Conversation

chidioguejiofor
Copy link

What does this PR do?

  • adds tests for CardItem component
  • adds tests for Cards component
  • adds tests for Home container

Description of Task to be completed?

  • Add tests for the files in modules/Home folder

How should this be manually tested?

  • run git pull command
  • run npm test
  • the coverage report should show that modules/Home has 100% coverage

Any background context you want to provide?

  • the files in the modules/Home folder have not yet been tested. This PR adds tests for them

What are the relevant pivotal tracker stories?

#160928262

Screenshots or gifs (if appropriate)

screen shot 2018-10-11 at 9 37 05 am

screen shot 2018-10-11 at 9 36 50 am

Questions:

  • none

houndci-bot
houndci-bot reviewed Oct 11, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-16 October 11, 2018 08:38 Inactive
@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-16 October 11, 2018 08:43 Inactive
houndci-bot
houndci-bot reviewed Oct 11, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-16 October 11, 2018 08:45 Inactive
houndci-bot
houndci-bot reviewed Oct 11, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-16 October 11, 2018 08:47 Inactive
houndci-bot
houndci-bot reviewed Oct 11, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-16 October 11, 2018 08:48 Inactive
houndci-bot
houndci-bot reviewed Oct 11, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

houndci-bot
houndci-bot reviewed Oct 11, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@coveralls
Copy link

coveralls commented Oct 11, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 195

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 24.064%
Totals Coverage Status
Change from base Build 193: 0.0%
Covered Lines: 83
Relevant Lines: 292
💛 - Coveralls

veeqtor
veeqtor approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@veeqtor veeqtor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, I like the concept of shallow rendering the components as function.

chore(Home-tests): add tests for modules/Home folder
8fe1019 
- adds tests for the "modules/Home" files
- ensures that all the tests have 100% coverage

[Finishes #160928262]
houndci-bot
houndci-bot reviewed Oct 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@chidioguejiofor chidioguejiofor added the Ready for merge Ready for TTL review and merge label Oct 12, 2018
@Chieze-Franklin Chieze-Franklin merged commit c52984e into staging Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@Lumexralph Lumexralph Lumexralph approved these changes

@veeqtor veeqtor veeqtor approved these changes

@Chieze-Franklin Chieze-Franklin Awaiting requested review from Chieze-Franklin

Assignees
No one assigned
Labels
Ready for merge Ready for TTL review and merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@chidioguejiofor @coveralls @houndci-bot @Lumexralph @veeqtor @Chieze-Franklin @kenware @nouwatinjacob