Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#161116965 Create tests for create team module #18

Merged
merged 1 commit into from
Oct 16, 2018
Merged

#161116965 Create tests for create team module #18

merged 1 commit into from
Oct 16, 2018

Conversation

Lumexralph
Copy link

What does this PR do?

  • add unit and integrated tests for Form component
  • add unit and integrated tests for create team container component
  • update Jest configuration to process image imported into components

Description of Task to be completed?

Add tests for the files in Create Team modules

It is important to write tests for components to ensure that when the components are updated, breaking changes do not occur to the app.
Also, tests make it easy for new members of the team to onboard to the codebase and also serves as a way to document our application

How should this be manually tested?

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

Story #161116965

Screenshots or gifs (if appropriate)

N/A

Questions: None

houndci-bot
houndci-bot reviewed Oct 11, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-18 October 11, 2018 08:48 Inactive
@Lumexralph Lumexralph added the WIP Work in progress label Oct 11, 2018
@coveralls
Copy link

coveralls commented Oct 11, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 267

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+7.9%) to 32.008%
Totals Coverage Status
Change from base Build 260: 7.9%
Covered Lines: 232
Relevant Lines: 691
💛 - Coveralls

@Lumexralph Lumexralph force-pushed the ch-161116965-create-team-module-test branch from 0cea258 to c60fc69 Compare October 11, 2018 09:34
houndci-bot
houndci-bot reviewed Oct 11, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-18 October 11, 2018 09:35 Inactive
@Lumexralph Lumexralph force-pushed the ch-161116965-create-team-module-test branch from c60fc69 to 5ae03f1 Compare October 11, 2018 09:40
@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-18 October 11, 2018 09:40 Inactive
houndci-bot
houndci-bot reviewed Oct 11, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@Lumexralph Lumexralph added Ready for code review and removed WIP Work in progress labels Oct 11, 2018
@Lumexralph Lumexralph requested review from Fattylee and removed request for chidioguejiofor October 11, 2018 09:49
@Lumexralph Lumexralph added Ready for merge Ready for TTL review and merge and removed Ready for code review labels Oct 12, 2018
@Lumexralph Lumexralph force-pushed the ch-161116965-create-team-module-test branch from 5ae03f1 to 12510e8 Compare October 12, 2018 08:25
houndci-bot
houndci-bot reviewed Oct 12, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-18 October 12, 2018 08:26 Inactive
@Lumexralph Lumexralph force-pushed the ch-161116965-create-team-module-test branch from 12510e8 to 70a3d02 Compare October 13, 2018 15:10
@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-18 October 13, 2018 15:10 Inactive
houndci-bot
houndci-bot reviewed Oct 13, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@Lumexralph Lumexralph force-pushed the ch-161116965-create-team-module-test branch from 70a3d02 to b7822e0 Compare October 14, 2018 21:21
@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-18 October 14, 2018 21:21 Inactive
houndci-bot
houndci-bot reviewed Oct 14, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@Lumexralph Lumexralph force-pushed the ch-161116965-create-team-module-test branch from b7822e0 to 4f97650 Compare October 15, 2018 17:41
@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-18 October 15, 2018 17:41 Inactive
houndci-bot
houndci-bot reviewed Oct 15, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@Lumexralph Lumexralph force-pushed the ch-161116965-create-team-module-test branch from 4f97650 to abf2b9e Compare October 15, 2018 18:05
houndci-bot
houndci-bot reviewed Oct 15, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-18 October 15, 2018 18:05 Inactive
chore(create team): create tests for create team module
14cecb8 
- add test for Form component
- add test for create team container component

[Finishes #161116965]
@Lumexralph Lumexralph force-pushed the ch-161116965-create-team-module-test branch from abf2b9e to 14cecb8 Compare October 16, 2018 13:32
houndci-bot
houndci-bot reviewed Oct 16, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@Chieze-Franklin Chieze-Franklin merged commit ee4b1ba into staging Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@ascii-dev ascii-dev ascii-dev approved these changes

@Fattylee Fattylee Fattylee approved these changes

@Chieze-Franklin Chieze-Franklin Awaiting requested review from Chieze-Franklin

Assignees
No one assigned
Labels
Ready for merge Ready for TTL review and merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Lumexralph @coveralls @houndci-bot @ascii-dev @Fattylee @Chieze-Franklin @nouwatinjacob