#161217628 User can search instantly on the homepage #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Oct 16, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module 'eslint-config-react'
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
at Array.reduceRight ()
at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)
ascii-dev
force-pushed
the
ft-user-get-instant-result-161217628
branch
from
651191c
to
e6fbf93
Compare
houndci-bot
reviewed
Oct 16, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module 'eslint-config-react'
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
at Array.reduceRight ()
at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)
Pull Request Test Coverage Report for Build 383
💛 - Coveralls |
nouwatinjacob
approved these changes
Oct 18, 2018
- search result is retrieved as soon as users type [Finishes #161217628]
ascii-dev
force-pushed
the
ft-user-get-instant-result-161217628
branch
from
e6fbf93
to
68870ee
Compare
houndci-bot
reviewed
Oct 18, 2018
There was a problem hiding this comment.
Some files could not be reviewed due to errors:
Cannot find module 'eslint-config-react'
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
at Array.reduceRight ()
at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
Before now, on the homepage, when a user searches for a team, they have to press the
enterkey before the search is been made, but now, once they start typing, the search is made.What are the relevant pivotal tracker stories?
#161217628
Screenshots or gifs (if appropriate)
Questions: