Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#161286798 Disable Request admin privilege button #50

Merged
merged 1 commit into from
Oct 18, 2018
Merged

#161286798 Disable Request admin privilege button #50

merged 1 commit into from
Oct 18, 2018

Conversation

nouwatinjacob
Copy link

@nouwatinjacob nouwatinjacob commented Oct 18, 2018 •
edited
Loading

What does this PR do?

Disable Request admin privilege button when the user has requested for admin privilege

Description of Task to be completed?

  • make sure the button is active or disable if the user has made a request or not

How should this be manually tested?

  • git pull
  • npm i
  • npm run dev
  • login to the application
  • click on the Request admin privilege button

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#161286798

Screenshots or gifs (if appropriate)

N/A

Questions:

N/A

@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-50 October 18, 2018 13:27 Inactive
houndci-bot
houndci-bot reviewed Oct 18, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@coveralls
Copy link

coveralls commented Oct 18, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 407

  • 6 of 14 (42.86%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 50.83%
Changes Missing Coverage Covered Lines Changed/Added Lines %
client/src/redux/actions/requests/index.js 4 7 57.14%
client/src/modules/common/Navbar/index.jsx 0 5 0.0%
Files with Coverage Reduction New Missed Lines %
client/src/modules/common/Navbar/index.jsx 2 1.28%
Totals Coverage Status
Change from base Build 405: -0.1%
Covered Lines: 411
Relevant Lines: 765
💛 - Coveralls

@nouwatinjacob nouwatinjacob force-pushed the ft-disable-request-button-161286798 branch from ff38004 to fb3a6c3 Compare October 18, 2018 14:11
@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-50 October 18, 2018 14:11 Inactive
houndci-bot
houndci-bot reviewed Oct 18, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@nouwatinjacob nouwatinjacob force-pushed the ft-disable-request-button-161286798 branch from fb3a6c3 to 8f25754 Compare October 18, 2018 14:18
@nouwatinjacob nouwatinjacob temporarily deployed to ghoulies-taps-client-pr-50 October 18, 2018 14:19 Inactive
houndci-bot
houndci-bot reviewed Oct 18, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@nouwatinjacob nouwatinjacob added Ready for merge Ready for TTL review and merge and removed Ready for code review labels Oct 18, 2018
feat(disable button): Disable Request admin privilege button
74770f7 
- create and action that check if user have requested for admin privilege
- disable button if user have requested for admin privilege
- write action and reducer test

[Finishes #161286798]
@nouwatinjacob nouwatinjacob force-pushed the ft-disable-request-button-161286798 branch from 8f25754 to 74770f7 Compare October 18, 2018 17:34
houndci-bot
houndci-bot reviewed Oct 18, 2018
View reviewed changes
Copy link

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Cannot find module 'eslint-config-react' 
Cannot find module 'eslint-config-react'
Referenced from: .eslintrc
Error: Cannot find module 'eslint-config-react'
    at ModuleResolver.resolve (/home/linters/node_modules/eslint/lib/util/module-resolver.js:74:19)
    at resolve (/home/linters/node_modules/eslint/lib/config/config-file.js:471:25)
    at load (/home/linters/node_modules/eslint/lib/config/config-file.js:542:26)
    at configExtends.reduceRight (/home/linters/node_modules/eslint/lib/config/config-file.js:421:36)
    at Array.reduceRight ()
    at applyExtends (/home/linters/node_modules/eslint/lib/config/config-file.js:403:28)
    at loadFromDisk (/home/linters/node_modules/eslint/lib/config/config-file.js:514:22)
    at Object.load (/home/linters/node_modules/eslint/lib/config/config-file.js:550:20)
    at Config.getLocalConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:228:44)
    at Config.getConfigHierarchy (/home/linters/node_modules/eslint/lib/config.js:180:43)

@Chieze-Franklin Chieze-Franklin merged commit b6dbc19 into staging Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@Lumexralph Lumexralph Lumexralph approved these changes

@phemonick phemonick phemonick approved these changes

Assignees
No one assigned
Labels
Ready for merge Ready for TTL review and merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nouwatinjacob @coveralls @houndci-bot @Lumexralph @phemonick @Chieze-Franklin