New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#160994866 Require GOOGLE_CLIENT_ID in app.json #8

Merged

Chieze-Franklin merged 1 commit into staging from bg-require-google-client-id-160994866

Oct 4, 2018

nouwatinjacob commented Oct 4, 2018 •

edited

Loading

What does this PR do?

Require GOOGLE_CLIENT_ID in the app.json for review app to use

Description of Task to be completed?

update the app.json to require GOOGLE_CLIENT_ID

How should this be manually tested?

N/A

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

Screenshots or gifs (if appropriate)

N/A

Questions:

N/A


          bg(environment variable): Require GOOGLE_CLIENT_ID in app.json

b5c242f

- update the app.json to require GOOGLE_CLIENT_ID

[Finishes #160994866]

nouwatinjacob deployed to ghoulies-taps-client-pr-8

October 4, 2018 17:08

View deployment

coveralls commented Oct 4, 2018

Pull Request Test Coverage Report for Build 48

0 of 0 changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 0.155%

Totals
Change from base Build 46:	0.0%
Covered Lines:	1
Relevant Lines:	446

💛 - Coveralls

Chieze-Franklin merged commit 3dbc1f7 into staging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment