#169776372 Fix heroku error #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nziokaivy
force-pushed
the
bg-demo-branch-69776372
branch
from
8fe976b
to
2b703f3
Compare
nziokaivy
requested review from
william000000,
NiyoEric,
julietezekwe,
hezronkimutai and
victkarangwa
victkarangwa
reviewed
Dec 9, 2019
There was a problem hiding this comment.
Nice job @ivymwende, I think we should all as a team learn from your commitment & initiative.
Just have a look at one comment I have just left.
src/index.js
Outdated
Comment on lines
15
to
17
| app.use('/', router); | ||
|
|
||
| app.use('/', router); | ||
|
|
There was a problem hiding this comment.
Can we remove one of these lines: app.use('/', router); ?
It seems that it's duplicated.
- Fix start script for production - Add route that checks for a non-existing route [Finishes #169776372]
nziokaivy
force-pushed
the
bg-demo-branch-69776372
branch
from
2b703f3
to
98d7295
Compare
victkarangwa
approved these changes
Dec 9, 2019
julietezekwe
approved these changes
Dec 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes Heroku error.
Description of Task to be completed?
How should this be manually tested?
https://team-odd-bn-backend-staging.herokuapp.com/Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#169776372
Screenshots (if appropriate)
Questions: