#170180280 Manager get all and specific user booking Requests #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
william000000
force-pushed
the
ft-get-all-and-specific-booking-request-170180280
branch
4 times, most recently
from
8c086d8
to
677ad56
Compare
william000000
changed the title
william000000
requested review from
ivymwende,
NiyoEric,
julietezekwe,
hezronkimutai and
victkarangwa
and removed request for
ivymwende
william000000
changed the title
NiyoEric
suggested changes
Dec 11, 2019
There was a problem hiding this comment.
Well done @william000000. I liked how you made it so simple to display all bookings. I request you add more test.
Comment on lines
+164
to
+166
| res.should.have.status(404); | ||
| res.body.should.be.an('object'); |
Comment on lines
+136
to
+134
| res.should.have.status(200); | ||
| res.body.should.be.an('object'); |
There was a problem hiding this comment.
Thank you @NiyoEric, I have already implemented
william000000
force-pushed
the
ft-get-all-and-specific-booking-request-170180280
branch
from
677ad56
to
bc6f186
Compare
NiyoEric
approved these changes
Dec 11, 2019
There was a problem hiding this comment.
Nice job @william000000
Just have a look at some feedback I left
william000000
force-pushed
the
ft-get-all-and-specific-booking-request-170180280
branch
from
bc6f186
to
fbc29ab
Compare
hezronkimutai
approved these changes
Dec 12, 2019
hezronkimutai
requested changes
Dec 12, 2019
victkarangwa
approved these changes
Dec 12, 2019
nziokaivy
approved these changes
Dec 12, 2019
…quest made - Get specific booking an accommodation request - Fix the issue where user was able to book an accommodation facility that s/he is not the owner - Test for get user booking request - Add swagger documentation [Finishes #170180280]
william000000
force-pushed
the
ft-get-all-and-specific-booking-request-170180280
branch
from
fbc29ab
to
e7dbed9
Compare
hezronkimutai
approved these changes
Dec 12, 2019
julietezekwe
approved these changes
Dec 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Manager get specific or all booking accommodation requests
Description of Task to be completed?
userIdHow should this be manually tested?
git clone https://github.com/andela/team-odd-bn-backend.gitcd project-folderand runnpm ito install all dependenciesgit checkout ft-get-all-and-specific-booking-request-170180280npx sequelize-cli db:seed:allnpm run dev-startAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#170180280
Screenshots (if appropriate)
Get all users' booking requests
Get specific user booking requests
Questions:
N/A