Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#170267352 Get all status types #56

Merged
merged 1 commit into from
Jan 1, 2020
Merged

Conversation

ivymwende
Copy link
Contributor

What does this PR do?

Get all trip status types.

Description of Task to be completed?

  • Add tests
  • Add verify token and verify email validations
  • Add status controller function and route

How should this be manually tested?

  • Clone this repository using the command: git clone https://github.com/andela/team-odd-bn-backend.git
  • Checkout to this branch using the command: git checkout ft-get-all-status-functionality-170267352
  • Run the application using the command: npm run dev-start
  • Run the tests using the command: npm test

Any background context you want to provide?

Users do not understand what different status ids stand for
so we are creating a route that gets all status types

What are the relevant pivotal tracker stories?

#170267352

Screenshots (if appropriate)

image

Questions:

src/tests/111-statusTests.js Outdated Show resolved Hide resolved
src/routes/api/statusRoute.js Show resolved Hide resolved
src/routes/api/statusRoute.js Show resolved Hide resolved
- Add tests
- Add verify token and verify email validations
- Add status controller function and route
[Finishes #170267352]
Copy link
Collaborator

@hezronkimutai hezronkimutai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice initiative @ivymwende .

Copy link
Contributor

@NiyoEric NiyoEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent job @ivymwende!. I think you are good to go!

@ivymwende ivymwende changed the title #170267352: Get all status types #170267352 Get all status types Dec 16, 2019
Copy link
Collaborator

@william000000 william000000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Work @ivymwende

Copy link
Collaborator

@victkarangwa victkarangwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Copy link
Contributor

@shemaeric shemaeric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shemaeric shemaeric merged commit 9510686 into develop Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants