Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#171177795 Return fully info about who liked or disliked #75

Merged
merged 2 commits into from
Feb 20, 2020
Merged

#171177795 Return fully info about who liked or disliked #75

merged 2 commits into from
Feb 20, 2020

Conversation

william000000
Copy link
Collaborator

@william000000 william000000 commented Feb 10, 2020 •
edited
Loading

What does this PR do?

  • Displays more detailed result which includes who liked or dislike

Description of Task to be completed?

  • Join booking table and like table
  • Display more about who liked or dislike

How should this be manually tested?

  • git clone https://github.com/andela/team-odd-bn-backend.git
  • cd team-odd-bn-backend
  • git checkout ch-user-like-dislike-171177795
  • npm install
  • Make sure your .env file is updated.
  • Drop existing migration npm run dropTables
  • Update migration npm run db-migrate
  • Populate the seed data npm run db-seed-dev
  • npm run dev-start check API in development

Create booking localhost:3000/api/v1/accommodations/{tripId}/likes.

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#171177795

Screenshots (if appropriate)

image

Questions:

N/A

@william000000 william000000 changed the title ch(likeAndDislike) Return fully info about who liked or disliked #171177795 Return fully info about who liked or disliked Feb 10, 2020
@ivymwende ivymwende temporarily deployed to team-odd-barefoot-backend February 10, 2020 20:35 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-barefoot-backend February 10, 2020 20:45 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-barefoot-backend February 10, 2020 20:48 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-barefoot-backend February 10, 2020 20:51 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-barefoot-backend February 10, 2020 20:58 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-barefoot-backend February 10, 2020 21:00 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-barefoot-backend February 10, 2020 21:11 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-bn-backend-staging February 10, 2020 21:14 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-bn-backend-staging February 10, 2020 21:26 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-bn-backend-staging February 10, 2020 21:36 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-bn-backend-staging February 10, 2020 21:40 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-barefoot-backend February 11, 2020 07:30 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-bn-backend-staging February 11, 2020 08:19 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-bn-backend-staging February 11, 2020 08:44 Inactive
@william000000 william000000 force-pushed the ch-user-like-dislike-171177795 branch 4 times, most recently from b3f66aa to e7614a9 Compare February 12, 2020 12:31
@ivymwende ivymwende temporarily deployed to team-odd-bn-backend-staging February 12, 2020 12:54 Inactive
hezronkimutai
hezronkimutai requested changes Feb 13, 2020
View reviewed changes
Copy link
Collaborator

@hezronkimutai hezronkimutai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fill in the PR description @william000000

NiyoEric
NiyoEric suggested changes Feb 13, 2020
View reviewed changes
Copy link
Contributor

@NiyoEric NiyoEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I 've tested likes/dislikes functionality and it is working as expected. Please take look the feedback I left

src/controllers/BookingController.js Outdated Show resolved Hide resolved
@william000000 william000000 force-pushed the ch-user-like-dislike-171177795 branch 2 times, most recently from 452de80 to 02ca351 Compare February 19, 2020 15:39
@william000000 william000000 added the Ready for review Task is done. It is ready to be reviewed label Feb 20, 2020
@ivymwende ivymwende temporarily deployed to team-odd-bn-backend-staging February 20, 2020 09:34 Inactive
@ivymwende ivymwende temporarily deployed to team-odd-bn-backend-staging February 20, 2020 11:04 Inactive
@victkarangwa @william000000
ch(booking): change user booking response
f3def80 
- include accommodation details
- include room details
[Start #171098744]
hezronkimutai
hezronkimutai reviewed Feb 20, 2020
View reviewed changes
Copy link
Collaborator

@hezronkimutai hezronkimutai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the failling tests @william000000

victkarangwa
victkarangwa approved these changes Feb 20, 2020
View reviewed changes
Copy link
Collaborator

@victkarangwa victkarangwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you are good to go!

@kipropbrian kipropbrian merged commit 6c8903c into develop Feb 20, 2020
@kipropbrian kipropbrian deleted the ch-user-like-dislike-171177795 branch February 20, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victkarangwa victkarangwa victkarangwa approved these changes

@hezronkimutai hezronkimutai hezronkimutai approved these changes

@NiyoEric NiyoEric NiyoEric approved these changes

@ivymwende ivymwende Awaiting requested review from ivymwende

@kipropbrian kipropbrian Awaiting requested review from kipropbrian

Assignees
No one assigned
Labels
Ready for review Task is done. It is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@william000000 @victkarangwa @hezronkimutai @NiyoEric @kipropbrian @ivymwende