Improve existing logical operation #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NiyongaboEric
requested review from
victkarangwa,
william000000,
hezronkimutai and
nziokaivy
NiyongaboEric
force-pushed
the
bg-frontend-design-improvement-171403437
branch
from
b6d7aa8
to
bd94c4e
Compare
hezronkimutai
requested changes
Feb 21, 2020
hezronkimutai
approved these changes
Feb 21, 2020
NiyongaboEric
force-pushed
the
bg-frontend-design-improvement-171403437
branch
from
bd94c4e
to
d963acd
Compare
william000000
approved these changes
Feb 24, 2020
kipropbrian
requested changes
Feb 24, 2020
NiyongaboEric
force-pushed
the
bg-frontend-design-improvement-171403437
branch
from
29361c9
to
a559d8b
Compare
- refactor code - add style - [Finishes #171403437]
NiyongaboEric
force-pushed
the
bg-frontend-design-improvement-171403437
branch
from
a559d8b
to
a08905c
Compare
kipropbrian
requested changes
Feb 25, 2020
NiyongaboEric
force-pushed
the
bg-frontend-design-improvement-171403437
branch
from
d0f91c3
to
2f405ab
Compare
william000000
approved these changes
Feb 26, 2020
NiyongaboEric
force-pushed
the
bg-frontend-design-improvement-171403437
branch
from
2f405ab
to
df81867
Compare
There was a problem hiding this comment.
Well done @NiyoEric
However, I've left some feedback. We can work together to get it done!
- improve current condition checking - update env modify multicity trip request - remove string comparison for trip request - check the status of the trip - edit test` - [Finishes #171403437]
NiyongaboEric
force-pushed
the
bg-frontend-design-improvement-171403437
branch
from
7a6d9a2
to
5c6d6a0
Compare
nziokaivy
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The PR helps to refactor the existing work.
Description of Task to be completed?
string comparisonHow should this be manually tested?
git clone https://github.com/andela/team-odd-bn-frontend.gitcd team-odd-bn-backendnpm installAny background context you want to provide?
The current work works well. However, we need to improve.
What are the relevant pivotal tracker stories?
#171403437
Screenshots (if appropriate)
Questions: