Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#171434652 Fix user interface styles #52

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

victkarangwa
Copy link
Collaborator

What does this PR do?

  • Fix the delete comment pop up style
  • Fix broken user table styles

Description of Task to be completed?

  • This PR fixes the styles for the table component and the popup styles for deleting comments

How should this be manually tested?

  • git clone https://github.com/andela/team-odd-bn-frontend.git
  • cd team-odd-bn-backend
  • git checkout bg-fix-user-interface-171434652
  • npm install
  • npm run dev to run server

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#171434652

Screenshots (if appropriate)

N/A

Questions:

N/A

Copy link
Collaborator

@NiyongaboEric NiyongaboEric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @victorkarangwa4

Copy link
Contributor

@nziokaivy nziokaivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @victorkarangwa4

@victkarangwa victkarangwa force-pushed the bg-fix-user-interface-171434652 branch 2 times, most recently from 7e1c529 to b5fb6f9 Compare February 27, 2020 15:00
Copy link
Collaborator

@william000000 william000000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just remove that console @kipropbrian mentioned otherwise, it looks good

- Fix the delete comment pop up style
- Fix broken user table
- Fix search functionality
[Finishes #171434652]
@hezronkimutai hezronkimutai merged commit bd7dda0 into develop Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants