-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ft notification pane 168049948 #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1e34855
to
38941b8
Compare
38941b8
to
a213f86
Compare
a213f86
to
269b597
Compare
269b597
to
32d5db3
Compare
32d5db3
to
64483ce
Compare
64483ce
to
db263e9
Compare
db263e9
to
c3e261b
Compare
c3e261b
to
2e924bc
Compare
2e924bc
to
6b2c2ea
Compare
6b2c2ea
to
3a6f215
Compare
3a6f215
to
1aba1ad
Compare
1aba1ad
to
67a9f04
Compare
Jordybastien
approved these changes
Nov 19, 2019
[Start #168049948,#168049963] - register(sign-up): a user should be able to sign up - feat(user-login): add user login functionality - add social login and forgot password link to login form - feature(user-profile): add view and edit profile - user can view and edit his/her profile - ft(get-notifications): get users notifications - add redux - set up notifications with modal - add notification counter to display number of unread - remove notification from login header - add tests and rebase
67a9f04
to
2db569e
Compare
gik-hub
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add notifications pane so that a user can view and interact with notifications
Description of Task to be completed?
How should this be manually tested?
ft-notification-pane-168049948
branchAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#168049948
Screenshots (if appropriate)
Questions:
N/A