#166240995 User profile creation #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 12, 2019
| import chaiHttp from 'chai-http'; | ||
| import app from '../src'; | ||
|
|
||
| const should = chai.should(); |
There was a problem hiding this comment.
'should' is assigned a value but never used no-unused-vars
deschantkn
force-pushed
the
ft-user-profiles-166240995
branch
from
1849b2d
to
855622c
Compare
rukundoeric
approved these changes
Jun 12, 2019
|
@deschantkn Fix the Merge conflicts |
Quantum-35
suggested changes
Jun 13, 2019
| @@ -0,0 +1,30 @@ | |||
| import models from '../../sequelize/models'; | |||
There was a problem hiding this comment.
I don't find any valid reason for creating two files pofiles.js and users.js. You can just move all the implementation in the user.js to ProfileController class to make it more readable.
Anything to say about this suggestion?
There was a problem hiding this comment.
No I think this logic is more sound than what I currently have. Will make the necessary changes
deschantkn
force-pushed
the
ft-user-profiles-166240995
branch
from
855622c
to
429c436
Compare
deschantkn
force-pushed
the
ft-user-profiles-166240995
branch
from
429c436
to
d698505
Compare
mifeille
approved these changes
Jun 13, 2019
Diama1
approved these changes
Jun 13, 2019
deschantkn
force-pushed
the
ft-user-profiles-166240995
branch
from
d698505
to
6b94709
Compare
- implement user profile creation - implement user profile fetching functionality - document endpoints - fix token middleware - make request validation middleware reusable [Finishes #166240995]
deschantkn
force-pushed
the
ft-user-profiles-166240995
branch
from
6b94709
to
a079120
Compare
Quantum-35
approved these changes
Jun 13, 2019
UhiriweAudace
pushed a commit
that referenced
this pull request
Jun 13, 2019
* feat: add registration validation errors * feat(profiles): implement profiles functionality - implement user profile creation - implement user profile fetching functionality - document endpoints - fix token middleware - make request validation middleware reusable [Finishes #166240995]
UhiriweAudace
pushed a commit
that referenced
this pull request
Jun 14, 2019
* feat: add registration validation errors * feat(profiles): implement profiles functionality - implement user profile creation - implement user profile fetching functionality - document endpoints - fix token middleware - make request validation middleware reusable [Finishes #166240995]
eliemugenzi
pushed a commit
that referenced
this pull request
Jun 19, 2019
* feat: add registration validation errors * feat(profiles): implement profiles functionality - implement user profile creation - implement user profile fetching functionality - document endpoints - fix token middleware - make request validation middleware reusable [Finishes #166240995]
Diama1
pushed a commit
that referenced
this pull request
Jul 17, 2019
* feat: add registration validation errors * feat(profiles): implement profiles functionality - implement user profile creation - implement user profile fetching functionality - document endpoints - fix token middleware - make request validation middleware reusable [Finishes #166240995]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enables user to create and update their profile information
Description of Task to be completed?
Implement the following endpoints:
PUT - /api/userGET - /profiles/:usernameHow should this be manually tested?
Run the server and use Postman to test
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#166240995
Screenshots (if appropriate)
N/A
Questions:
N/A