#166240994 Enable social login #26

mifeille · 2019-06-13T16:01:31Z

What does this PR do?

Enables social login.

Description of Task to be completed?

Allow users to login with their pre-existing social media accounts

How should this be manually tested?

Clone the repo, cd into it and RUN yarn install to install all the dependencies, then RUN yarn dev to start the server.

Log in the account that you want to use and go to the browser and write :
http://localhost:3001/api/auth/login/facebook for Facebook
http://localhost:3001/api/auth/login/google for Google
http://localhost:3001/api/auth/login/twitter for Twitter

What are the relevant pivotal tracker stories?
#166240994

houndci-bot · 2019-06-13T16:01:53Z

test/auth.js

 import server from '../src/index';

 const { expect } = chai;
 chai.use(chaiHttp);

+const authenticatedUser = request.agent(server);


'authenticatedUser' is assigned a value but never used no-unused-vars

houndci-bot · 2019-06-13T16:01:53Z

src/middleware/socialAccountExists.js

+      if (currentUser) {
+        console.log('this is not a new user');
+        console.log(currentUser);
+        console.log(currentUser.length);


Unexpected console statement no-console

houndci-bot · 2019-06-13T16:01:54Z

src/middleware/socialAccountExists.js

+    }).then((currentUser) => {
+      if (currentUser) {
+        console.log('this is not a new user');
+        console.log(currentUser);


Unexpected console statement no-console

houndci-bot · 2019-06-13T16:01:54Z

src/middleware/socialAccountExists.js

+      },
+    }).then((currentUser) => {
+      if (currentUser) {
+        console.log('this is not a new user');


Unexpected console statement no-console

houndci-bot · 2019-06-13T16:01:54Z

src/middleware/socialAccountExists.js

+      id, displayName, provider
+    } = req.user;
+    console.log('hey');
+    console.log(req.user);


Unexpected console statement no-console

houndci-bot · 2019-06-13T16:01:57Z

src/config/passportSetup.js

+    },
+  ),
+);
+passport.use(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2019-06-13T16:01:57Z

src/config/passportSetup.js

+      done(null, profile);
+    },
+  ),
+);


Unexpected newline before ')' function-paren-newline

houndci-bot · 2019-06-13T16:01:57Z

src/config/passportSetup.js

+    },
+  ),
+);
+passport.use(


Unexpected newline after '(' function-paren-newline

src/config/passportSetup.js

houndci-bot · 2019-06-13T16:01:58Z

src/config/passportSetup.js

+
+dotenv.config();
+
+passport.use(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2019-06-16T13:22:04Z

test/auth.test.js

@@ -4,16 +4,14 @@ import dotenv from 'dotenv';
 import server from '../src/index';
 import db from '../src/sequelize/models';
 import tokenHelper from '../src/helpers/Token.helper';
-
+import socialController from '../src/middleware/socialAccountExists';


'socialController' is defined but never used no-unused-vars

houndci-bot · 2019-06-16T13:22:05Z

src/middleware/socialAccountExists.js

+const userExists = {
+  async google(req, res, next) {
+    const { emails, displayName } = req.user;
+    console.log(emails[0].value);


Unexpected console statement no-console

src/api/routes/authRouter.js

houndci-bot · 2019-06-16T13:22:05Z

src/api/routes/authRouter.js

+authRouter.get('/login/google/redirect', passport.authenticate('google', { session: false }), google, socialLogin.googleLogin);
+
+// routes for facebook
+authRouter.get('/login/facebook', passport.authenticate('facebook', { scope: ['email'] }),);


A space is required after ',' comma-spacing

houndci-bot · 2019-06-16T13:22:05Z

src/api/controllers/socialLogin.js

+      verified: req.user.emails[0].verified,
+      socialId: req.user.id,
+    });
+    //console.log(newUser.dataValues);


Expected exception block, space or tab after '//' in comment spaced-comment

houndci-bot · 2019-06-16T13:22:06Z

src/api/controllers/socialLogin.js

+
+const userInfo = {
+  async googleLogin(req, res) {
+    console.log(req.user);


Unexpected console statement no-console

houndci-bot · 2019-06-16T13:51:56Z

src/config/passportSetup.js

+    profileFields: ['id', 'displayName', 'photos', 'email'],
+  },
+  (accessToken, refreshToken, profile, done) => { done(null, profile); },
+),);


A space is required after ',' comma-spacing

houndci-bot · 2019-06-16T13:51:57Z

src/config/passportSetup.js

+    callbackURL: '/api/auth/login/google/redirect',
+  },
+  (accessToken, refreshToken, profile, done) => { done(null, profile); },
+),);


A space is required after ',' comma-spacing

houndci-bot · 2019-06-16T14:06:04Z

src/config/passportSetup.js

+    profileFields: ['id', 'displayName', 'photos', 'email'],
+  }, (accessToken, refreshToken, profile, done) => { done(null, profile); },
+),);
+passport.use(new TwitterTokenStrategy(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2019-06-16T14:06:04Z

src/config/passportSetup.js

+    callbackURL: '/api/auth/login/facebook/redirect',
+    profileFields: ['id', 'displayName', 'photos', 'email'],
+  }, (accessToken, refreshToken, profile, done) => { done(null, profile); },
+),);


A space is required after ',' comma-spacing
Unexpected newline before ')' function-paren-newline

houndci-bot · 2019-06-16T14:06:04Z

src/config/passportSetup.js

+  },
+  (accessToken, refreshToken, profile, done) => { done(null, profile); },
+),);
+passport.use(new FacebookStrategy(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2019-06-16T14:16:30Z

src/config/passportSetup.js

+  clientSecret: process.env.FCBK_APP_SECRET,
+  callbackURL: '/api/auth/login/facebook/redirect',
+  profileFields: ['id', 'displayName', 'photos', 'email']
+}, (accessToken, refreshToken, profile, done) => { done(null, profile); },),);


A space is required after ',' comma-spacing

houndci-bot · 2019-06-16T14:16:30Z

src/config/passportSetup.js

+  clientSecret: process.env.GOOGLE_SECRET,
+  includeEmail: true,
+  callbackURL: '/api/auth/login/google/redirect'
+}, (accessToken, refreshToken, profile, done) => { done(null, profile); },),);


A space is required after ',' comma-spacing

houndci-bot · 2019-06-16T14:24:44Z

src/config/passportSetup.js

+  consumerSecret: process.env.TWITTER_APP_SECRET,
+  callbackURL: 'http://localhost:3001/api/auth/login/twitter/redirect'
+},
+(token, tokenSecret, profile, done) => { done(null, profile); }));


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-06-16T14:24:44Z

src/config/passportSetup.js

+},
+(accessToken, refreshToken, profile, done) => { done(null, profile); },),);
+
+passport.use(new TwitterTokenStrategy({


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-06-16T14:24:44Z

src/config/passportSetup.js

+  callbackURL: '/api/auth/login/facebook/redirect',
+  profileFields: ['id', 'displayName', 'photos', 'email']
+},
+(accessToken, refreshToken, profile, done) => { done(null, profile); },),);


A space is required after ',' comma-spacing
Expected a newline before ')' function-paren-newline

houndci-bot · 2019-06-16T14:24:44Z

src/config/passportSetup.js

+},
+(accessToken, refreshToken, profile, done) => { done(null, profile); },),);
+
+passport.use(new FacebookStrategy({


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-06-16T14:24:44Z

src/config/passportSetup.js

+  includeEmail: true,
+  callbackURL: '/api/auth/login/google/redirect'
+},
+(accessToken, refreshToken, profile, done) => { done(null, profile); },),);


A space is required after ',' comma-spacing
Expected a newline before ')' function-paren-newline

houndci-bot · 2019-06-16T14:24:44Z

src/config/passportSetup.js

+
+dotenv.config();
+
+passport.use(new GoogleStrategy({


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-06-16T14:34:41Z

src/api/routes/authRouter.js

+// callback route for twitter to redirect to
+
+authRouter.get('/login/twitter/redirect', passport.authenticate('twitter', { session: false }),
+  twitter, socialLogin.twitterLogin);


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-06-16T14:34:41Z

src/api/routes/authRouter.js

+
+// callback route for twitter to redirect to
+
+authRouter.get('/login/twitter/redirect', passport.authenticate('twitter', { session: false }),


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-06-16T14:34:41Z

src/api/routes/authRouter.js

+// callback route for facebook to redirect to
+
+authRouter.get('/login/facebook/redirect', passport.authenticate('facebook', { session: false }),
+  google, socialLogin.facebookLogin);


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-06-16T14:34:42Z

src/api/routes/authRouter.js

+
+// callback route for facebook to redirect to
+
+authRouter.get('/login/facebook/redirect', passport.authenticate('facebook', { session: false }),


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-06-16T14:34:42Z

src/api/routes/authRouter.js

+// callback route for google to redirect to
+
+authRouter.get('/login/google/redirect', passport.authenticate('google', { session: false }),
+  google, socialLogin.googleLogin);


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-06-16T14:34:42Z

src/api/routes/authRouter.js

+
+// callback route for google to redirect to
+
+authRouter.get('/login/google/redirect', passport.authenticate('google', { session: false }),


Expected a newline after '(' function-paren-newline

houndci-bot · 2019-06-16T14:43:57Z

src/config/passportSetup.js

+  }, (accessToken, refreshToken, profile, done) => {
+    done(null, profile);
+  }
+),);


A space is required after ',' comma-spacing
Unexpected newline before ')' function-paren-newline

houndci-bot · 2019-06-16T15:17:03Z

src/config/passportSetup.js

+  },
+  (token, tokenSecret, profile, done) => {
+    done(null, profile);
+  }));


Expected a newline before ')' function-paren-newline

houndci-bot · 2019-06-16T15:17:03Z

src/config/passportSetup.js

+  },
+  (accessToken, refreshToken, profile, done) => {
+    done(null, profile);
+  },),);


A space is required after ',' comma-spacing
Expected a newline before ')' function-paren-newline

houndci-bot · 2019-06-16T15:17:03Z

src/config/passportSetup.js

+  },
+  (accessToken, refreshToken, profile, done) => {
+    done(null, profile);
+  }),);


A space is required after ',' comma-spacing
Expected a newline before ')' function-paren-newline

src/config/passportSetup.js

Quantum-35 · 2019-06-17T13:14:38Z

package.json

    "handlebars": "^4.1.2",
+    "install": "^0.12.2",


Remove unused packages.

Quantum-35 · 2019-06-17T13:15:17Z

package.json

@@ -37,7 +39,11 @@
    "morgan": "^1.9.1",
    "nodemailer": "^6.2.1",
    "passport": "^0.4.0",
+    "passport-auth0": "^1.1.0",


Remove this Package.

Quantum-35 · 2019-06-17T13:16:37Z

src/api/controllers/socialLogin.js

+    if (newUser) {
+      const {
+        id, firstName, lastName, email, provider
+      } = newUser.dataValues;


const {
dataValues: {id, firstName, lastName, email, provider}
} = newUser;

Quantum-35 · 2019-06-17T13:22:06Z

src/config/passportSetup.js

+  {
+    consumerKey: process.env.TWITTER_ID,
+    consumerSecret: process.env.TWITTER_APP_SECRET,
+    callbackURL: 'http://localhost:3001/api/auth/login/twitter/redirect'


Remove the hardcoded base_url.

${}

mifeille added the WIP label Jun 13, 2019

houndci-bot reviewed Jun 13, 2019

View reviewed changes

mifeille force-pushed the ft-enable-social-login-166240994 branch from 3b28c8a to c1bff32 Compare June 16, 2019 13:21