#166241007 - Search Functionality Added to Authors Haven #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UhiriweAudace
force-pushed
the
ft-search-functionality-166241007
branch
7 times, most recently
from
5cac4c8
to
70eb0af
Compare
eliemugenzi
approved these changes
Jun 26, 2019
UhiriweAudace
force-pushed
the
ft-search-functionality-166241007
branch
from
70eb0af
to
425bfc0
Compare
EmyRukundo
approved these changes
Jun 26, 2019
deschantkn
approved these changes
Jun 27, 2019
UhiriweAudace
force-pushed
the
ft-search-functionality-166241007
branch
from
425bfc0
to
7ab121f
Compare
UhiriweAudace
force-pushed
the
ft-search-functionality-166241007
branch
12 times, most recently
from
183646e
to
a5d1966
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
test/paginate.test.js
Outdated
| .get('/api/articles?page=1&limit=10') | ||
| .send((err, res) => { | ||
| console.log('=======FOUND RESULT======'); | ||
| console.log(res.body); |
There was a problem hiding this comment.
Unexpected console statement no-console
test/paginate.test.js
Outdated
| .request(app) | ||
| .get('/api/articles?page=1&limit=10') | ||
| .send((err, res) => { | ||
| console.log('=======FOUND RESULT======'); |
There was a problem hiding this comment.
Unexpected console statement no-console
UhiriweAudace
force-pushed
the
ft-search-functionality-166241007
branch
from
a5d1966
to
03ff96d
Compare
Quantum-35
approved these changes
Jun 28, 2019
UhiriweAudace
added
Merged
Diama1
pushed a commit
that referenced
this pull request
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR, I implemented the endpoints that will enable any user/client to send the request for making a search in Authors Haven
Description of Task to be completed?
Having the following Endpoints working:
GET /api/articles?author=<Author's Username>GET /api/articles?tag=<Article's tag>GET /api/articles?title=<Article's title>GET /api/articles?keywords=<Keywords>How should this be manually tested?
cd tesla-ahyarn installoryarnsequelize db:migratefor this command make sure that thesequelize-clipackage is installed globallyyarn devyarn test:localAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#166241007
Screenshots (if appropriate)
N/A
Questions:
Before You Code
https://docs.google.com/document/d/1Dh6VZBn61Y2b-lvV8oOafSoH1m7ilT0wXf6iDXAcz8o/edit?usp=sharing