Merge pull request #71 from andela/bg-fix-facebook-auth-171406524

#171406524 Fix facebook authentication
andela · Feb 21, 2020 · 1f4cd28 · 1f4cd28
2 parents 4b51c64 + de8a078
commit 1f4cd28
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 3 deletions.
diff --git a/src/config/passport.js b/src/config/passport.js
@@ -16,7 +16,7 @@ passport.use(new GoogleStrategy({
 passport.use(new FacebookStrategy({
   clientID: process.env.FACEBOOK_APP_ID,
   clientSecret: process.env.FACEBOOK_APP_SECRET,
-  callbackURL: '/api/auth/facebook/redirect',
+  callbackURL: `${process.env.API_URL}/api/auth/facebook/redirect`,
   scope: ['public_profile', 'email'],
-  profileFields: ['id', 'email', 'name']
+  profileFields: ['id', 'email', 'name', 'photos']
 }, facebookAuthMiddleware));
diff --git a/src/middlewares/facebook-auth.middleware.js b/src/middlewares/facebook-auth.middleware.js
@@ -11,6 +11,7 @@ export default async (accessToken, refreshToken, profile, done) => {
       lastName: facebookProfile.last_name,
       email: facebookProfile.email,
       password: BcryptService.hashPassword(Math.random().toString(36)),
+      profilePicture: facebookProfile.picture.data.url,
       isVerified: true
     };
     const { dataValues } = await UserService.addUser(userdata);

diff --git a/src/middlewares/google-auth.middleware.js b/src/middlewares/google-auth.middleware.js
@@ -11,6 +11,7 @@ export default async (accessToken, refreshToken, profile, done) => {
       lastName: googleProfile.family_name,
       email: googleProfile.email,
       password: BcryptService.hashPassword(Math.random().toString(36)),
+      profilePicture: googleProfile.picture,
       isVerified: true
     };
     const { dataValues } = await UserService.addUser(userdata);

diff --git a/src/tests/fixtures/users.fixture.js b/src/tests/fixtures/users.fixture.js
@@ -270,7 +270,12 @@ export const facebookProfile = {
   _json: {
     first_ame: 'userfirstname',
     last_name: 'userlastname',
-    email: 'facebookuser@gmail.com'
+    email: 'facebookuser@gmail.com',
+    picture: {
+      data: {
+        url: 'ufhuierhfierhfiuhreiufheiru'
+      }
+    }
   }
 };
 export const OAuthTokens = {