Skip to content

Commit

Permalink
Merge pull request #68 from andela/ch-Add-trip-status-171355993
Browse files Browse the repository at this point in the history
#171355993 Add view trip request with its status
  • Loading branch information
bdushimi committed Feb 19, 2020
2 parents e6b30cd + 9b29e54 commit c42c5ba
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 4 deletions.
1 change: 0 additions & 1 deletion src/controllers/trip.controller.js
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ class TripController {
const offset = (page - 1) * limit;

const results = await TripService.findByPropertyAndCountAll({ userId }, { offset, limit });

ResponseService.setSuccess(200, 'List of requested trips', {
pageMeta: paginationHelper({
count: results.count, rows: results.rows, offset, limit
Expand Down
2 changes: 1 addition & 1 deletion src/models/trip.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default (sequelize, DataTypes) => {
Trip.belongsTo(models.Users, { foreignKey: 'userId', targetKey: 'id' });
Trip.belongsTo(models.Location, { foreignKey: 'originId', targetKey: 'id' });
Trip.belongsTo(models.Location, { foreignKey: 'destinationId', targetKey: 'id' });
Trip.belongsTo(models.Request, { foreignKey: 'requestId', targetKey: 'id' });
Trip.belongsTo(models.Request, { foreignKey: 'requestId', targetKey: 'id', as: 'request' });
};
Trip.afterCreate(({ dataValues }) => {
emitter.emit('request-created', dataValues);
Expand Down
2 changes: 1 addition & 1 deletion src/routes/trip.route.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ const router = express.Router();
router.post('/one-way', authMiddleware.checkUserLoggedIn, authMiddleware.checkIfUserHaveManager, oneWayTripValidation, TripController.requestOneWayTrip); // One way trip route
router.post('/return', authMiddleware.checkUserLoggedIn, authMiddleware.checkIfUserHaveManager, returnTripValidation, TripController.requestReturnTrip); // Return trip route
router.post('/multi-city', authMiddleware.checkUserLoggedIn, authMiddleware.checkIfUserHaveManager, multiCityTripValidation, TripController.requestMultiCityTrip);
router.get('/requests', authMiddleware.checkUserLoggedIn, requestValidation, TripController.userTripRequestList); // user request list route
router.get('/requests', authMiddleware.checkUserLoggedIn, requestValidation, TripController.userTripRequestList); // manager's request list route
router.get('/locations', authMiddleware.checkUserLoggedIn, TripController.viewAvailableLocations);
router.post('/requests/:tripId/comments', authMiddleware.checkUserLoggedIn, UserValidation.validateUserComment, CommentController.addCommentOnTripRequest); // user comment on request trip route
router.delete('/:tripId/comments/:commentId', authMiddleware.checkUserLoggedIn, UserValidation.validateDeleteTripComment, TripMiddleware.checkTripExist, CommentMiddleware.checkCommentExist, CommentController.deleteComment); // user deletes comment route
Expand Down
7 changes: 6 additions & 1 deletion src/services/trip.service.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import models from '../models';

const { Trip, Location } = models;
const { Trip, Location, Request } = models;

/**
*
Expand Down Expand Up @@ -63,6 +63,7 @@ class TripService {
attributes: [
'userId',
'tripType',
'requestId',
'originId',
'destinationId',
'departureDate',
Expand All @@ -71,6 +72,10 @@ class TripService {
'createdAt',
'updatedAt'
],
include: [{
model: Request,
as: 'request',
}],
offset,
limit
});
Expand Down

0 comments on commit c42c5ba

Please sign in to comment.