#169817538 User signup feature #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…previous local pull error
… travisci timeout failures
…ove unnecessary codes
adesege
suggested changes
Dec 10, 2019
|
@higustave-ops Ensure you resolve hound errors before requesting for reviews again. |
adesege
suggested changes
Dec 10, 2019
victor-abz
reviewed
Dec 11, 2019
higustave-ops
requested review from
adesege and
victor-abz
and removed request for
adesege
higustave-ops
force-pushed
the
ft-user-signup-169817538
branch
from
d043d84
to
1e777ce
Compare
… coverage by ignoring modules folder's files
higustave-ops
force-pushed
the
ft-user-signup-169817538
branch
from
1e777ce
to
af7d40f
Compare
erickyvand
reviewed
Dec 11, 2019
|
Add a more descriptive error message
|
|
I'm unable to create a new user because the error message is not descriptive. What's the right pattern for adding a password? |
victor-abz
reviewed
Dec 17, 2019
gadishimwe
suggested changes
Dec 17, 2019
erickyvand
reviewed
Dec 17, 2019
|
LGTM |
adesege
suggested changes
Dec 18, 2019
| @@ -8,21 +8,14 @@ export default class Response { | |||
| * Creates an instance of Response. | |||
| @@ -0,0 +1,54 @@ | |||
| /** | |||
| * @exports | |||
| * @class UsersController | |||
|
Your travis build is failing @higustave-ops |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create a user signup featureDescription of Task to be completed?
To create a user signup feature by allowing a user to signup. A signing up user should input his/her (firstName, lastName, userName, email and password) in order to be able to signupHow should this be manually tested?
CMDor anyTERMINALnpm installnpm run devfor Postman testing Andnpm run testfor mocha testinglocalhost:3000/api/auth/signupbodythenx-www-form-urlencodedfirstName,lastName,email,passwordand their respective values (Key: Value)pairSENDon the top right corner of PostmanWhat are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Postman screenshotTest screenshotQuestions: