-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#169817539 User account verify #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e27610
to
a3f80c3
Compare
erickyvand
reviewed
Dec 24, 2019
gadishimwe
reviewed
Dec 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
victor-abz
suggested changes
Dec 24, 2019
8c0e0ee
to
de4a6d7
Compare
71cda50
to
d7aaf43
Compare
victor-abz
approved these changes
Dec 27, 2019
884cd4d
to
a5f1844
Compare
erickyvand
approved these changes
Dec 30, 2019
gadishimwe
approved these changes
Dec 30, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
- Create user account verification - User account verification mocha test - User account verification Documentation using Swagger [Starts #169817539]
a5f1844
to
5b294fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Create user account verify feature
Description of Task to be completed?
To create a user account verification feature by allowing a user to be able to verify his/her account after a successful signup. A signing up user should copy the token sent to his email and then paste it into Headers Authorization of POSTMAN in order to be able to verify his account
How should this be manually tested?
CMD
or anyTERMINAL
npm install
npm run dev
for Postman testing Andnpm run test
for mocha testinglocalhost:3000/api/auth/signup
body
thenx-www-form-urlencoded
firstName
,lastName
,email
,password
and their respective values (Key: Value
)pairSEND
on the top right corner of Postmanlocalhost:3000/api/auth/account_verify
What are the relevant pivotal tracker stories?
Screenshots (if appropriate)
Postman screenshot Upon successful user account verification
Postman screenshot once provided token has expired
Postman screenshot once trying to verify an already verified account
Test screenshot
Questions: