Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#169817539 User account verify #25

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

higustave-ops
Copy link
Contributor

@higustave-ops higustave-ops commented Dec 20, 2019

What does this PR do?

Create user account verify feature

Description of Task to be completed?

To create a user account verification feature by allowing a user to be able to verify his/her account after a successful signup. A signing up user should copy the token sent to his email and then paste it into Headers Authorization of POSTMAN in order to be able to verify his account

How should this be manually tested?

  • Clone this repo
  • Navigate in the repo root using CMD or any TERMINAL
  • Install all packages using npm install
  • Type npm run dev for Postman testing And npm run test for mocha testing
  • Open postman choose POST and type localhost:3000/api/auth/signup
  • Click body then x-www-form-urlencoded
  • Fill in firstName, lastName, email, password and their respective values (Key: Value)pair
  • Click SEND on the top right corner of Postman
  • Go to your email (The one you signed up with)
  • Copy the token provided in it
  • In postman choose PATCH and type localhost:3000/api/auth/account_verify
  • Paste it (token) into POSTMAN's Headers-->Authorization field
  • Click send button, and once the token is not expired, your account gets verified.

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Postman screenshot Upon successful user account verification
image

Postman screenshot once provided token has expired
image

Postman screenshot once trying to verify an already verified account
image

Test screenshot
image

Questions:

Copy link
Contributor

@gadishimwe gadishimwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/controllers/auth.controller.js Outdated Show resolved Hide resolved
src/controllers/auth.controller.js Outdated Show resolved Hide resolved
src/controllers/auth.controller.js Show resolved Hide resolved
src/controllers/auth.controller.js Outdated Show resolved Hide resolved
src/services/user.service.js Outdated Show resolved Hide resolved
src/services/user.service.js Outdated Show resolved Hide resolved
src/services/user.service.js Outdated Show resolved Hide resolved
@higustave-ops higustave-ops force-pushed the ft-user-account-verify-169817539 branch 2 times, most recently from 71cda50 to d7aaf43 Compare December 24, 2019 15:05
@higustave-ops higustave-ops force-pushed the ft-user-account-verify-169817539 branch 5 times, most recently from 884cd4d to a5f1844 Compare December 27, 2019 15:57
Copy link
Contributor

@gadishimwe gadishimwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

- Create user account verification
- User account verification mocha test
- User account verification Documentation using Swagger

[Starts #169817539]
@higustave-ops higustave-ops merged commit 4a201ea into develop Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants