#170720630 Assign a requester to a manager #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdushimi
requested changes
Jan 22, 2020
src/routes/settings.route.js
Outdated
|
|
||
| const router = express.Router(); | ||
|
|
||
| router.patch('/roles', authMiddleware.checkUserLoggedIn, validateUserRole, authMiddleware.verifyIfUserIsAdmin, SettingsController.changeUserRole); | ||
| router.patch('/:userId/line-manager/:lineManagerId', authMiddleware.checkUserLoggedIn, authMiddleware.verifyIfUserIsAdmin, assignManagerValidation, SettingsController.assignRequesterToManager); |
There was a problem hiding this comment.
This route would be correct if a user can have many managers since it is not the case, I suggest you use a convenient route.
victor-abz
reviewed
Jan 23, 2020
gadishimwe
force-pushed
the
ft-assign-requester-to-manager-170720630
branch
from
c0d042a
to
674ca90
Compare
- Add assigning user to a manager controller - Add assign manager validations - Add tests and documentation of this Feature [starts #170720630]
gadishimwe
force-pushed
the
ft-assign-requester-to-manager-170720630
branch
from
674ca90
to
cf54484
Compare
bdushimi
approved these changes
Jan 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add assigning requester to a manager feature
Description of Task to be completed?
How should this be manually tested?
then
$ npm run testor you can use Postman to send a request to /api/users/settings/:userId/line-manager/:lineManagerId
What are the relevant pivotal tracker stories?
#170720630
Screenshots