Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#170804355 Fix trip and request relation #56

Merged
merged 2 commits into from
Jan 23, 2020
Merged

#170804355 Fix trip and request relation #56

merged 2 commits into from
Jan 23, 2020

Conversation

gadishimwe
Copy link
Contributor

What does this PR do?

Fix trip and request relation

Description of Task to be completed?

  • Add requestId into trip model
  • Remove tripId from both trip and request models
  • Refactor the code to reflect the changes

How should this be manually tested?

$ git clone https://github.com/andela/the_spinners-backend.git
$ cd the_spinners-backend
$ git checkout bg-fix-trip-request-relation-170804355

then
$ npm run test

or you can use Postman to send a get request to /api/trips/multi-city, /api/trips/one-way, /api/trips/return

What are the relevant pivotal tracker stories?

#170804355

Screenshots

Screen Shot 2020-01-21 at 10 15 40

Screen Shot 2020-01-21 at 10 13 30

adesege
adesege suggested changes Jan 21, 2020
View reviewed changes
src/migrations/20191231150619-create-trip.js Outdated Show resolved Hide resolved
src/migrations/20200101101824-create-request.js Outdated Show resolved Hide resolved
src/models/request.js Show resolved Hide resolved
src/tests/fixtures/trip.fixture.js Outdated Show resolved Hide resolved
src/validations/multi-city-trip.validation.js Outdated Show resolved Hide resolved
src/validations/trip.validation.js Outdated Show resolved Hide resolved
@adesege adesege added Work In Progress Work not yet finished and removed needs review labels Jan 21, 2020
@gadishimwe gadishimwe added needs review and removed Work In Progress Work not yet finished labels Jan 21, 2020
@gadishimwe gadishimwe force-pushed the bg-fix-trip-request-relation-170804355 branch 2 times, most recently from 272eb36 to 24ab2fe Compare January 23, 2020 12:45
@gadishimwe
Bg(tables relation): fix trip and request relation
b88cb1f 
- Add requestId into trip model
- Remove tripId from both trip and request models
- Refactor the code to reflect the changes

[starts #170804355]
@gadishimwe gadishimwe force-pushed the bg-fix-trip-request-relation-170804355 branch 2 times, most recently from 05d4ea9 to a301c9b Compare January 23, 2020 13:50
@gadishimwe gadishimwe force-pushed the bg-fix-trip-request-relation-170804355 branch from a301c9b to 9e1ce46 Compare January 23, 2020 13:56
@bdushimi bdushimi merged commit 3d6c636 into develop Jan 23, 2020
@adesege adesege mentioned this pull request Jan 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adesege adesege adesege requested changes

@erickyvand erickyvand Awaiting requested review from erickyvand

@victor-abz victor-abz Awaiting requested review from victor-abz

@higustave-ops higustave-ops Awaiting requested review from higustave-ops

Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gadishimwe @adesege @bdushimi