#159987724 Users should be able to see time it takes to read an article #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Sep 11, 2018
| ); | ||
| }, | ||
|
|
||
| down: (queryInterface) => { |
There was a problem hiding this comment.
Unexpected block statement surrounding arrow body; move the returned value immediately after the => arrow-body-style
| @@ -0,0 +1,18 @@ | |||
| module.exports = { | |||
| up: (queryInterface, Sequelize) => { | |||
There was a problem hiding this comment.
Unexpected block statement surrounding arrow body; move the returned value immediately after the => arrow-body-style
Extended the article model to include timeToRead column. Calculate time to read article then save article. - Add calculateTimeToRead helper method - Add pre save hook - include relevant tests
CEOehis
force-pushed
the
ft-article-read-time-159987724
branch
from
c419885
to
c841dad
Compare
Pull Request Test Coverage Report for Build 283
💛 - Coveralls |
CEOehis
assigned lauragift21 and unassigned aknwosu, emmaadesile, d-beloved and GodswillOnuoha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add read time to an article.
Description of Task to be completed?
Extended the article model to include
timeToReadcolumn. Calculate timeto read an article then save the article.
How should this be manually tested?
Run
npm run migrateRun
npm run start:devsend a
POSTrequest to/api/articles/to create an articleWhat are the relevant pivotal tracker stories?
#159987724