Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(likeDislike): update like and dislike endpoints #53

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

iamuchejude
Copy link
Contributor

What does this PR do?

Fix errors in like and dislike endpoints and updated documentation

Description of the task?

  • Fixed errors in like and dislike endpoint.
  • Added like and dislike endpoints to documentation.

How to manually test

  • Clone the repository
  • cd to thor-ah
  • Setup postgres database
  • Create .env using the format in .env.sample
  • Run npm install
  • Run npm run start:dev
  • Open documentation with a web browser via http://localhost:3000/api-doc

What are the relevant Pivotal Tracker Story?

#159987708

- fix errors with like and dislike endpoints
- add like and dislike to documentation
@coveralls
Copy link

Pull Request Test Coverage Report for Build 437

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 93.068%

Files with Coverage Reduction New Missed Lines %
server/controllers/likeDislike.js 1 76.83%
Totals Coverage Status
Change from base Build 432: -0.01%
Covered Lines: 1828
Relevant Lines: 1928

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 437

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 93.068%

Files with Coverage Reduction New Missed Lines %
server/controllers/likeDislike.js 1 76.83%
Totals Coverage Status
Change from base Build 432: -0.01%
Covered Lines: 1828
Relevant Lines: 1928

💛 - Coveralls

Copy link
Contributor

@CEOehis CEOehis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aknwosu aknwosu merged commit df21830 into develop Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants