#161282285 Track if User has liked/disliked current comment #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 589
💛 - Coveralls |
CEOehis
force-pushed
the
bg-track-comment-likes-161282285
branch
from
9879f60
to
cba5f06
Compare
- Fix comment like/dislike creation handler
CEOehis
force-pushed
the
bg-track-comment-likes-161282285
branch
from
cba5f06
to
91f6425
Compare
waleCloud
reviewed
Oct 19, 2018
- include relevant tests
houndci-bot
reviewed
Oct 19, 2018
| */ | ||
| const hasReaction = (reactions, userId) => reactions.some( | ||
| reaction => reaction.userId === userId | ||
| ); |
There was a problem hiding this comment.
Unexpected newline before ')' function-paren-newline
| * | ||
| * @returns {bool} retrurns true/false | ||
| */ | ||
| const hasReaction = (reactions, userId) => reactions.some( |
There was a problem hiding this comment.
Unexpected newline after '(' function-paren-newline
| @@ -0,0 +1,47 @@ | |||
| import { expect } from 'chai'; | |||
| import hasReaction from '../../utils/hasReaction'; | |||
There was a problem hiding this comment.
Missing file extension for "../../utils/hasReaction" import/extensions
| @@ -0,0 +1,47 @@ | |||
| import { expect } from 'chai'; | |||
There was a problem hiding this comment.
Missing file extension for "chai" import/extensions
| @@ -3,6 +3,7 @@ import { | |||
| Article, Comment, User, Reply, CommentLikesDislike, CommentHistory | |||
| } from '../models'; | |||
| import isEmpty from '../utils/is_empty'; | |||
| import hasReaction from '../utils/hasReaction'; | |||
There was a problem hiding this comment.
Missing file extension for "../utils/hasReaction" import/extensions
|
@waleCloud I have covered the uncovered lines. Thanks. |
waleCloud
approved these changes
Oct 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable tracking user like/dislike state for each comment
Description of Task to be completed?
What are the relevant pivotal tracker stories?
#161282285