Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/157610021/notification invite ui designs #148

Merged
merged 17 commits into from
May 23, 2018

Conversation

Orlayhemmy
Copy link
Contributor

What does this PR do?

It re-designs the UI for sending invites to online users

Description of Task to be completed?

  • add tabs to hold players in the game and online users
  • add notifications on all pages navbar
  • fix multiplicating players
  • fix abandon game error

What are the relevant pivotal tracker stories?

Story Id #157610021

Screenshots (if appropriate)

screen

screen shot 2018-05-16 at 5 09 30 pm

@Spectrumsun Spectrumsun temporarily deployed to thorin-cfh-staging-pr-148 May 23, 2018 09:54 Inactive
@Orlayhemmy Orlayhemmy temporarily deployed to thorin-cfh-staging-pr-148 May 23, 2018 09:57 Inactive
@coveralls
Copy link

coveralls commented May 23, 2018

Pull Request Test Coverage Report for Build 620

  • 14 of 71 (19.72%) changed or added relevant lines in 2 files are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 32.312%

Changes Missing Coverage Covered Lines Changed/Added Lines %
config/socket/socket.js 7 32 21.88%
config/passport.js 7 39 17.95%
Files with Coverage Reduction New Missed Lines %
config/socket/socket.js 2 7.97%
config/passport.js 3 27.17%
Totals Coverage Status
Change from base Build 614: 0.2%
Covered Lines: 349
Relevant Lines: 888

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants