#156882158 Landing page with effective UI/UX #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user can see error message on sign up page show image on sign up page [Delivers #157283077]
- Resign the landing page - Create css style for the landing page [Deliver #155882158]
houndci-bot
reviewed
May 4, 2018
public/js/controllers/index.js
Outdated
|
|
||
|
|
||
|
|
||
| <<<<<<< HEAD |
Pull Request Test Coverage Report for Build 306
💛 - Coveralls |
chuzksy-codeactive
force-pushed
the
feeture/156882158/design-landing-page
branch
from
8893b73
to
53e3f5d
Compare
chuzksy-codeactive
requested review from
Spectrumsun and
emmabaye
and removed request for
amarachukwu-agbo and
kenoseni
emmabaye
reviewed
May 4, 2018
| @@ -8,3 +8,6 @@ coverage | |||
| /data | |||
| /.env | |||
| /build | |||
| privacy.html | |||
|
|
|||
| meet-the-team.html | |||
There was a problem hiding this comment.
Great job. However, I think you should specify the path to the html files in case another file with the same name exists in another folder. Also, there should be a new line at the end of this file.
| "clientSecret": "APP_SECRET", | ||
| "callbackURL": "http://cfh.io/auth/facebook/callback" | ||
| "clientID": "180680672583006", | ||
| "clientSecret": "3cfd8dd9cb1116aedc701bd2138b66d2", |
There was a problem hiding this comment.
This is sensitive information. The secret token should not be included in the code. Use a dotenv file to hold this information instead.
Spectrumsun
reviewed
May 4, 2018
There was a problem hiding this comment.
Good job with the redesign. But I discovered that some of your styles are not working well on Heroku. The Signup and login buttons on the landing page is not styled on Herkou. Please fix the style.
Here is the like to the deployed version. https://thorin-cfh-staging-pr-91.herokuapp.com. Thanks
- Resign the landing page - Create css style for the landing page [Deliver #155882158]
chuzksy-codeactive
force-pushed
the
feeture/156882158/design-landing-page
branch
from
53e3f5d
to
6cb5602
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Design landing page for the software product
Description of Task to be completed?
Users should see a landing page with effective UI/UX
How should this be manually tested?
What are the relevant pivotal tracker stories?
Story ID #156882158