Skip to content

Commit

Permalink
Merge pull request #31 from andela/ch-setup-eslint-165054398
Browse files Browse the repository at this point in the history
#165054398 Setup Eslint
  • Loading branch information
puritybirir committed Apr 5, 2019
2 parents 75d3699 + bfa16c9 commit a364b58
Show file tree
Hide file tree
Showing 8 changed files with 370 additions and 25 deletions.
65 changes: 65 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
{
"root": true,
"env": {
"browser": true,
"es6": true,
"node": true,
"jest": true
},
"extends": ["airbnb", "plugin:prettier/recommended", "prettier/react"],
"globals": {
"Atomics": "readonly",
"SharedArrayBuffer": "readonly"
},
"parserOptions": {
"ecmaFeatures": {
"jsx": true
},
"ecmaVersion": 2016,
"sourceType": "module"
},
"plugins": ["react", "prettier"],
"rules": {
"prettier/prettier": "error",
"newlines-between": "always",
"react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }],
"quotes": ["error", "double"],
"parserOptions": {
"allowImportExportEverywhere": true,
"sourceType": "module"
},
"eol-last": ["error", "always"],
"import/prefer-default-export": "off",
"import/resolver": {
"node": { "extensions": [".js"] }
},
"one-var": 0,
"one-var-declaration-per-line": 0,
"new-cap": 0,
"consistent-return": 0,
"no-param-reassign": 0,
"comma-dangle": 0,
"curly": ["error", "multi-line"],
"import/no-unresolved": [2, { "commonjs": true }],
"no-shadow": ["error", { "allow": ["req", "res", "err", "done"] }],
"valid-jsdoc": [
"error",
{
"requireReturn": true,
"requireReturnType": true,
"requireParamDescription": false,
"requireReturnDescription": true
}
],
"require-jsdoc": [
"error",
{
"require": {
"FunctionDeclaration": true,
"MethodDefinition": false,
"ClassDeclaration": false
}
}
]
}
}
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,6 @@
node_modules
dist
.coveralls.yml
coverage
coverage

.vscode
3 changes: 3 additions & 0 deletions .hound.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
eslint:
enabled: true
config_file: .eslintrc.json
3 changes: 3 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"singleQuote": false
}
8 changes: 7 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
},
"homepage": "https://github.com/andela/titan-dev-ah-frontend#readme",
"dependencies": {
"eslint": "^5.16.0",
"react": "^16.8.6",
"react-dom": "^16.8.6"
},
Expand All @@ -46,9 +45,16 @@
"babel-loader": "^8.0.5",
"coveralls": "^3.0.3",
"css-loader": "^2.1.1",
"eslint": "^5.16.0",
"eslint-config-airbnb": "^17.1.0",
"eslint-plugin-import": "^2.16.0",
"eslint-plugin-jsx-a11y": "^6.2.1",
"eslint-plugin-prettier": "^3.0.1",
"eslint-plugin-react": "^7.12.4",
"html-webpack-plugin": "^3.2.0",
"jest": "^24.6.0",
"node-sass": "^4.11.0",
"prettier": "^1.16.4",
"react-test-renderer": "^16.8.6",
"sass-loader": "^7.1.0",
"style-loader": "^0.23.1",
Expand Down
16 changes: 6 additions & 10 deletions src/views/Home.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
import React, { Component } from "react";
import React from "react";

export default class Home extends Component {
render() {
return (
<div>
<h2 className="home-container">Hello world, from Titan-Devs</h2>
</div>
);
}
}
export default () => (
<div>
<h2 className="home-container">Hello world, from Titan-Devs</h2>
</div>
);
11 changes: 5 additions & 6 deletions src/views/Home.test.js
Original file line number Diff line number Diff line change
@@ -1,11 +1,10 @@
import React from "react";
import Home from "./Home";
import renderer from "react-test-renderer";
import Home from "./Home";

describe('Home component', () => {
describe("Home component", () => {
test("it matches the snapshot", () => {
const tree = renderer.create(<Home />).toJSON();
expect(tree).toMatchSnapshot();
const tree = renderer.create(<Home />).toJSON();
expect(tree).toMatchSnapshot();
});
});
})

Loading

0 comments on commit a364b58

Please sign in to comment.