-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#165427095 Design the notification wrapper, view, delete notifications #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Musigwa! Bro, can you please rename the PR title?
Use the recommended title from engineering playbook.
609b361
to
377a3fd
Compare
86340e9
to
818383e
Compare
ba654f2
to
d04d00f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done Mr. @Musigwa ,
- My first recommendation would be to split the navbar component into small components so that it becomes more maintainable.
- Minimize the inline style by using class and id.
I left some comment inside the document. You can check them, and let me know when you are done.
8ceccb7
to
d165bad
Compare
d165bad
to
a1fccd8
Compare
src/__tests__/__components__/AppBars/__snapshots__/Navbar.test.js.snap
Outdated
Show resolved
Hide resolved
d2683da
to
2eacd27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
23ab01b
to
9a6db40
Compare
600e459
to
589b53f
Compare
What does this PR do?
Description of Task to be completed?
get notifications
actionHow should this be manually tested?
/ft-create-notification-container-165427095
branchyarn start
to start the application then, you shall see the notification button on the top navigation bar with the number the current user's notifications if any.X
buttonunread
toread
which will be shown by the icon change.Any background context you want to provide?
test()
instead ofit()
for consistency.What are the relevant pivotal tracker stories?