This repository has been archived by the owner on May 9, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2
#161291007 Implement user profile update route #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 4, 2018
5d40b98
to
59fa6f6
Compare
Pull Request Test Coverage Report for Build 352
💛 - Coveralls |
KvNGCzA
reviewed
Nov 5, 2018
KvNGCzA
reviewed
Nov 5, 2018
KvNGCzA
reviewed
Nov 5, 2018
I think we should use 200 x 200 as the minimum dimensions and 1MB as the maximum file size
It is important that route only functions for a verified user
I'm good with the token not expiring |
59fa6f6
to
a6977d9
Compare
houndci-bot
reviewed
Nov 6, 2018
a6977d9
to
4568327
Compare
4568327
to
a415d9e
Compare
houndci-bot
reviewed
Nov 6, 2018
dd05516
to
d2204d8
Compare
andela-moe
reviewed
Nov 7, 2018
d2204d8
to
3c03a22
Compare
houndci-bot
reviewed
Nov 7, 2018
3c03a22
to
531d0e3
Compare
531d0e3
to
c7a55cf
Compare
c7a55cf
to
8610965
Compare
houndci-bot
reviewed
Nov 7, 2018
8610965
to
5227a0b
Compare
5227a0b
to
035b6ff
Compare
- add profile columns to the user table - build route to update a user's profile - implement cloudinary image upload for profile avatars - fix error handler [Finishes #161291007]
- remove backend functionality to upload image(multipart/form-data) - add validations on user update route - update babel packages to fix transpilation problem on heroku [#161291007]
035b6ff
to
6aa4fb6
Compare
@mbilesanmi LGTM. |
1 similar comment
@mbilesanmi LGTM. |
sulenchy
reviewed
Nov 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Enable user profile to be updated
Description of Task to be completed?
set up Multer to handle multipart/form-data, for avatar uploads.PATCH /users/:userId
route to update a user's profileHow should this be manually tested?
feature/161291007/user-profile-update
npm install
to install required packagesnpm start
to start up the serverPOST http://localhost:3000/api/v1/users/signup
providing necessary request body as shown in screen shots belowPATCH http://localhost:3000/api/v1/users/:userid
providing necessary request body as shown in screen shots belowAny background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#161291007
Screenshots (if appropriate)
Signup a user:
![screen shot 2018-11-05 at 12 10 49 am](https://user-images.githubusercontent.com/31810086/47971264-26764e00-e090-11e8-9ed1-7d2e3155314d.png)
Update the user's profile:
![screen shot 2018-11-08 at 4 42 17 pm](https://user-images.githubusercontent.com/31810086/48209396-54e87780-e375-11e8-8eed-84e99548f15f.png)
Questions: