This repository has been archived by the owner on May 9, 2021. It is now read-only.
#162167286 implement comment on a comment #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KvNGCzA
requested review from
tersoo-atsen,
andela-moe,
mbilesanmi and
Darthrighteous
Pull Request Test Coverage Report for Build 703
💛 - Coveralls |
KvNGCzA
force-pushed
the
feature/162167286/comment-on-comment
branch
from
8029bc4
to
1f2f085
Compare
Darthrighteous
temporarily deployed
to
valinor-ah-backend-stagi-pr-75
houndci-bot
reviewed
Nov 25, 2018
KvNGCzA
force-pushed
the
feature/162167286/comment-on-comment
branch
from
58f639a
to
759d772
Compare
KvNGCzA
force-pushed
the
feature/162167286/comment-on-comment
branch
from
759d772
to
570a40e
Compare
KvNGCzA
force-pushed
the
feature/162167286/comment-on-comment
branch
from
570a40e
to
2cef4e5
Compare
KvNGCzA
force-pushed
the
feature/162167286/comment-on-comment
branch
from
2cef4e5
to
2dbec7c
Compare
KvNGCzA
force-pushed
the
feature/162167286/comment-on-comment
branch
from
2dbec7c
to
8e600a1
Compare
- create commentOnComment controller - refactor helpers - create commentOnComment route - refactor fetch article by id controller - create test for app.js - create commentOnComment model [Finishes #162167286]
KvNGCzA
force-pushed
the
feature/162167286/comment-on-comment
branch
from
8e600a1
to
5060a2c
Compare
houndci-bot
reviewed
Nov 27, 2018
KvNGCzA
force-pushed
the
feature/162167286/comment-on-comment
branch
4 times, most recently
from
0abd4ec
to
4c021eb
Compare
houndci-bot
reviewed
Nov 28, 2018
KvNGCzA
force-pushed
the
feature/162167286/comment-on-comment
branch
2 times, most recently
from
f4f149e
to
54f0a5c
Compare
houndci-bot
reviewed
Nov 28, 2018
- improve getCommentsCount helper - remove articleId from CommentReply models [Finishes #162167286]
KvNGCzA
force-pushed
the
feature/162167286/comment-on-comment
branch
from
54f0a5c
to
b85e073
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implement comment on a comment functionality
Description of Task to be completed?
How should this be manually tested?
npm inpm startnpm run db-initapi/v1/articles/comments/:{commentId}route,send
{ reply: 'reply text here' }Any background context you want to provide?
What are the relevant pivotal tracker stories?
#162167286
Screenshots (if appropriate)
Questions: