Skip to content
This repository has been archived by the owner on May 9, 2021. It is now read-only.

#162633744 create social login controller and route #83

Merged
merged 1 commit into from
Dec 15, 2018

Conversation

KvNGCzA
Copy link
Contributor

@KvNGCzA KvNGCzA commented Dec 13, 2018

What does this PR do?

have the api/v1/auth/social route working

Description of Task to be completed?

  • create social login route
  • create create social login controller
  • create social login validation
  • add test for social login
  • add article image to articles model and migration

How should this be manually tested?

  • start the server
  • send the following information via a post request
{
	"fullName": "full name",
	"email": "email@email.com",
	"socialType": "twitter",
	"socialId": "79364981278217401",
	"avatarUrl": "https://yourimagehere.com"
}

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#162633744

Screenshots (if appropriate)

screen shot 2018-12-13 at 2 43 21 pm

screen shot 2018-12-13 at 2 43 51 pm

Questions:

N/A

Link to review app:

@KvNGCzA KvNGCzA requested review from mbilesanmi and Darthrighteous and removed request for mbilesanmi December 13, 2018 13:47
@Darthrighteous Darthrighteous temporarily deployed to valinor-ah-backend-stagi-pr-83 December 13, 2018 13:47 Inactive
@coveralls
Copy link

coveralls commented Dec 13, 2018

Pull Request Test Coverage Report for Build 910

  • 19 of 19 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 93.247%

Totals Coverage Status
Change from base Build 871: 0.5%
Covered Lines: 1087
Relevant Lines: 1127

💛 - Coveralls

@KvNGCzA KvNGCzA force-pushed the feature/162633744/social-auth branch from fe1f512 to 27b2d5b Compare December 13, 2018 17:52
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-backend-stagi-pr-83 December 13, 2018 17:52 Inactive
@KvNGCzA KvNGCzA force-pushed the feature/162633744/social-auth branch from 27b2d5b to 8bb0763 Compare December 13, 2018 18:08
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-backend-stagi-pr-83 December 13, 2018 18:08 Inactive
- create social login route
- create create social login controller
- create social login validation
- add test for social login
- add article image to articles model and migration

[Finishes #162633744]
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants