Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#162380294 create static signup page #15

Merged
merged 2 commits into from
Dec 8, 2018

Conversation

sulenchy
Copy link

@sulenchy sulenchy commented Dec 5, 2018

What is it this PR doing

Create static signup page

Description of Task to be completed?

  • create the small screen view
  • create the big screen view
  • add styles
  • write snapshot tests for the component

How should this be manually tested?

  • clone this repo
  • branch out to feature/162380294/static-signup-page branch
  • run npm install
  • run npm run start:dev

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#162380294

Screenshots (if appropriate)

screen shot 2018-12-08 at 7 20 38 pm

screen shot 2018-12-08 at 7 21 02 pm

Questions:

N/A

Link to review App

Review App

public/assets/styles/signup.scss Outdated Show resolved Hide resolved
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 53547a9 to 12fc3d2 Compare December 5, 2018 13:30
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 12fc3d2 to 6793032 Compare December 5, 2018 13:55
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 6793032 to d81174c Compare December 5, 2018 14:05
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from d81174c to 81a4c3f Compare December 5, 2018 14:23
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
public/assets/styles/index.scss Outdated Show resolved Hide resolved
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 81a4c3f to 5961fd4 Compare December 5, 2018 14:55
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 5961fd4 to 4784c71 Compare December 5, 2018 15:20
@KvNGCzA KvNGCzA requested a deployment to valinor-ah-frontend-stag-pr-15 December 5, 2018 15:33 Abandoned
@KvNGCzA KvNGCzA requested a deployment to valinor-ah-frontend-stag-pr-15 December 5, 2018 15:33 Abandoned
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-15 December 5, 2018 15:33 Inactive
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 4784c71 to fbd6dce Compare December 5, 2018 15:58
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 5, 2018 15:58 Inactive
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from fbd6dce to 5155704 Compare December 5, 2018 21:39
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 5, 2018 21:39 Inactive
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-15 December 6, 2018 08:03 Inactive
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 5155704 to d11c4e8 Compare December 6, 2018 08:15
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 6, 2018 08:15 Inactive
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from d11c4e8 to 07d2776 Compare December 6, 2018 10:15
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 6, 2018 10:16 Inactive
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 9716a8b to 91f1517 Compare December 8, 2018 12:37
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 8, 2018 12:37 Inactive
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 91f1517 to d49f88e Compare December 8, 2018 12:41
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 8, 2018 12:41 Inactive
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from d49f88e to 6624326 Compare December 8, 2018 12:59
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 8, 2018 12:59 Inactive
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 6624326 to de63c48 Compare December 8, 2018 15:27
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 8, 2018 15:28 Inactive
Copy link

@augustineezinwa augustineezinwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from de63c48 to 79db150 Compare December 8, 2018 15:59
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 8, 2018 15:59 Inactive
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
public/assets/styles/signup.scss Outdated Show resolved Hide resolved
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 79db150 to 752e899 Compare December 8, 2018 16:04
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 8, 2018 16:04 Inactive
- create small screen view
- create big screen view
- add styles
- write snapshot test for the component

[Finishes #162380294]
src/components/signup/SignUpPage.js Outdated Show resolved Hide resolved
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 752e899 to 7608a1e Compare December 8, 2018 21:21
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 8, 2018 21:21 Inactive
public/styles/signup.scss Outdated Show resolved Hide resolved
public/styles/signup.scss Outdated Show resolved Hide resolved
public/styles/signup.scss Outdated Show resolved Hide resolved
public/styles/signup.scss Outdated Show resolved Hide resolved
public/styles/signup.scss Outdated Show resolved Hide resolved
public/styles/signup.scss Outdated Show resolved Hide resolved
public/styles/signup.scss Outdated Show resolved Hide resolved
public/styles/signup.scss Outdated Show resolved Hide resolved
public/styles/signup.scss Outdated Show resolved Hide resolved
public/styles/mixins.scss Outdated Show resolved Hide resolved
@sulenchy sulenchy force-pushed the feature/162380294/static-signup-page branch from 7608a1e to 0e1d64d Compare December 8, 2018 21:46
@sulenchy sulenchy temporarily deployed to valinor-ah-frontend-stag-pr-15 December 8, 2018 21:46 Inactive
- modify the mobile view
- modify the web view

[Finishes #162380294]
@mbilesanmi mbilesanmi merged commit a191d70 into develop Dec 8, 2018
@mbilesanmi mbilesanmi deleted the feature/162380294/static-signup-page branch December 8, 2018 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants