-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#162380294 create static signup page #15
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Dec 5, 2018
53547a9
to
12fc3d2
Compare
houndci-bot
reviewed
Dec 5, 2018
12fc3d2
to
6793032
Compare
houndci-bot
reviewed
Dec 5, 2018
6793032
to
d81174c
Compare
houndci-bot
reviewed
Dec 5, 2018
d81174c
to
81a4c3f
Compare
houndci-bot
reviewed
Dec 5, 2018
81a4c3f
to
5961fd4
Compare
houndci-bot
reviewed
Dec 5, 2018
5961fd4
to
4784c71
Compare
4784c71
to
fbd6dce
Compare
houndci-bot
reviewed
Dec 5, 2018
fbd6dce
to
5155704
Compare
5155704
to
d11c4e8
Compare
d11c4e8
to
07d2776
Compare
9716a8b
to
91f1517
Compare
91f1517
to
d49f88e
Compare
d49f88e
to
6624326
Compare
houndci-bot
reviewed
Dec 8, 2018
6624326
to
de63c48
Compare
augustineezinwa
approved these changes
Dec 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
de63c48
to
79db150
Compare
houndci-bot
reviewed
Dec 8, 2018
79db150
to
752e899
Compare
- create small screen view - create big screen view - add styles - write snapshot test for the component [Finishes #162380294]
mbilesanmi
reviewed
Dec 8, 2018
mbilesanmi
suggested changes
Dec 8, 2018
752e899
to
7608a1e
Compare
houndci-bot
reviewed
Dec 8, 2018
7608a1e
to
0e1d64d
Compare
houndci-bot
reviewed
Dec 8, 2018
- modify the mobile view - modify the web view [Finishes #162380294]
0e1d64d
to
48f7736
Compare
mbilesanmi
approved these changes
Dec 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it this PR doing
Create static signup page
Description of Task to be completed?
How should this be manually tested?
Any background context you want to provide?
N/A
What are the relevant pivotal tracker stories?
#162380294
Screenshots (if appropriate)
Questions:
N/A
Link to review App
Review App