Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#162381835 Build navigation bar and footer #19

Merged
merged 1 commit into from
Dec 12, 2018
Merged

#162381835 Build navigation bar and footer #19

merged 1 commit into from
Dec 12, 2018
+1,089 −68

Conversation

tersoo-atsen
Copy link

@tersoo-atsen tersoo-atsen commented Dec 6, 2018 •
edited
Loading

What does this PR do?

Build the header and footer for desktop and mobile view

Description of Task to be completed?

  • write tests for components
  • add header component
  • add footer component

How should this be manually tested?

  • npm run dev

The site's header and footer should be visible on every relevant page

Any background context you want to provide?

  • N/A

What are the relevant pivotal tracker stories?

#162381835

Screenshots (if appropriate)

screen shot 2018-12-07 at 11 51 21 am

screen shot 2018-12-07 at 11 50 56 am

Questions:

N/A

Review App link

Heroku review app

houndci-bot
houndci-bot reviewed Dec 6, 2018
View reviewed changes
public/styles/index.scss Outdated Show resolved Hide resolved
public/styles/index.scss Outdated Show resolved Hide resolved
public/styles/Header.scss Outdated Show resolved Hide resolved
public/styles/Header.scss Outdated Show resolved Hide resolved
public/styles/Header.scss Outdated Show resolved Hide resolved
public/styles/Header.scss Outdated Show resolved Hide resolved
public/styles/Header.scss Outdated Show resolved Hide resolved
public/styles/Header.scss Outdated Show resolved Hide resolved
public/styles/Header.scss Outdated Show resolved Hide resolved
public/styles/Header.scss Outdated Show resolved Hide resolved
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 25c7349 to 0cbf170 Compare December 6, 2018 10:41
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 0cbf170 to 37437e7 Compare December 7, 2018 09:40
houndci-bot
houndci-bot reviewed Dec 7, 2018
View reviewed changes
public/styles/Header.scss Outdated Show resolved Hide resolved
public/styles/Header.scss Outdated Show resolved Hide resolved
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch 3 times, most recently from e195100 to 6ea51c4 Compare December 7, 2018 11:17
@KvNGCzA KvNGCzA closed this Dec 7, 2018
@KvNGCzA KvNGCzA reopened this Dec 7, 2018
@tersoo-atsen tersoo-atsen changed the title #162381835 Build navbar and footer components #162381835 Build navigation bar and footer Dec 7, 2018
sulenchy
sulenchy reviewed Dec 8, 2018
View reviewed changes
package.json Show resolved Hide resolved
sulenchy
sulenchy reviewed Dec 8, 2018
View reviewed changes
public/styles/Footer.scss Outdated Show resolved Hide resolved
sulenchy
sulenchy reviewed Dec 8, 2018
View reviewed changes
public/styles/Header.scss Outdated Show resolved Hide resolved
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch 3 times, most recently from 519c4fb to 05152fb Compare December 8, 2018 08:11
KvNGCzA
KvNGCzA reviewed Dec 8, 2018
View reviewed changes
src/App.js Outdated Show resolved Hide resolved
public/styles/Footer.scss Outdated Show resolved Hide resolved
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 05152fb to 86c1655 Compare December 8, 2018 10:13
KvNGCzA
KvNGCzA suggested changes Dec 8, 2018
View reviewed changes
src/components/common/header/NavBar.js Outdated Show resolved Hide resolved
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 86c1655 to 9683ffa Compare December 9, 2018 07:49
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 9, 2018 07:49 Inactive
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 10, 2018 23:08 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 9780e70 to 10a6e29 Compare December 11, 2018 00:08
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 11, 2018 00:08 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 10a6e29 to 668109d Compare December 11, 2018 06:53
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 11, 2018 06:53 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 668109d to d9008e6 Compare December 11, 2018 07:23
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 11, 2018 07:23 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from d9008e6 to 519ffca Compare December 11, 2018 08:11
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 11, 2018 08:12 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 519ffca to 9bebba1 Compare December 11, 2018 08:26
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 11, 2018 08:26 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 9bebba1 to 4a19221 Compare December 11, 2018 19:26
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 11, 2018 19:26 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 4a19221 to 21ae2cd Compare December 11, 2018 19:42
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 11, 2018 19:42 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 21ae2cd to 9594327 Compare December 11, 2018 22:02
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 11, 2018 22:02 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 9594327 to 5b745b3 Compare December 12, 2018 08:06
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 12, 2018 08:06 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from 5b745b3 to d718358 Compare December 12, 2018 08:56
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 12, 2018 08:56 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from d718358 to cf45f15 Compare December 12, 2018 09:14
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 12, 2018 09:14 Inactive
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from cf45f15 to d21febe Compare December 12, 2018 10:58
@KvNGCzA KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-19 December 12, 2018 10:58 Inactive
@tersoo-atsen
feature(navigation): navbar and footer
ec4fb79 
- write tests
- add header component
- add footer component

[Starts #162381835]
@tersoo-atsen tersoo-atsen force-pushed the feature/162381835/build-navbar-and-footer branch from d21febe to ec4fb79 Compare December 12, 2018 11:09
@mbilesanmi mbilesanmi merged commit c8b337c into develop Dec 12, 2018
@mbilesanmi mbilesanmi deleted the feature/162381835/build-navbar-and-footer branch December 12, 2018 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@sulenchy sulenchy sulenchy left review comments

@KvNGCzA KvNGCzA KvNGCzA requested changes

@augustineezinwa augustineezinwa Awaiting requested review from augustineezinwa

@Darthrighteous Darthrighteous Awaiting requested review from Darthrighteous

@mbilesanmi mbilesanmi Awaiting requested review from mbilesanmi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tersoo-atsen @KvNGCzA @houndci-bot @sulenchy @mbilesanmi