#161290964 Build local login feature #31

tersoo-atsen · 2018-12-19T14:50:17Z

What does this PR do?

Have user be able to login to their Author's Haven accounts

Description of Task to be completed?

add tests
add login action creators
add welcome page component

How should this be manually tested?

run npm start to spin up the server
open localhost:3000 to view the landing page
use redux dev tool to observe the state and state history
navigate to the login page and login with a valid user email
go to your inbox look for the email from Author's Haven and click on the link
you should be directed to the welcome page and logged in now

Any background context you want to provide?

N/A

What are the relevant pivotal tracker stories?

#161290964

Screenshots (if appropriate)

Questions:

N/A

Review App

src/components/welcome/WelcomePage.js

sulenchy

By default, the landing page displays an error from google. Below is the snapshot of the page

I think it is a bug

andela-moe

In your App.js file on line 21 you happen to be using componentWillMount() which at this point has been deprecated and moreover if you would want to check the status of the user after the component (in this cace the App) is rendered then you would consider using ComponentDIdMount versus what you currently have.

This resource should provide more insight -> https://daveceddia.com/where-fetch-data-componentwillmount-vs-componentdidmount/

src/actions/loginActions.js

houndci-bot · 2018-12-20T16:42:45Z

src/components/login/LoginPage.js

@@ -84,14 +102,14 @@ export class LoginPage extends Component {
                {/* Email input div */}
                <div id="login-form">
                  <h5>Sign in with your email</h5>
-                  <form id="login-form">
+                  <form onSubmit={this.handleSubmit} id="login-form">
                    <div className="row login-form-section text-center">
                      <div className="col-md-8 offset-md-2">
                        <div className="input-group mb-4 login-group">
                          <div className="input-group-prepend">
                            <span className="input-group-text transparent email-addon" id="basic-addon1"><img src={emailIcon} alt="email icon" /></span>
                          </div>


Trailing spaces not allowed no-trailing-spaces

houndci-bot · 2018-12-20T16:42:45Z

src/actions/loginActions.js

+)
+  .then(res => res.json(), error => dispatch(
+    globalFailure(['We were unable to log you in, please try again.', error])
+  ))


Unexpected newline before ')' function-paren-newline

houndci-bot · 2018-12-20T16:42:45Z

src/actions/loginActions.js

+export const logUserIn = tokenQueryString => dispatch => fetch(
+  `${process.env.API_BASE_URL}/users/login${tokenQueryString}`
+)
+  .then(res => res.json(), error => dispatch(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2018-12-20T16:42:45Z

src/actions/loginActions.js

+
+export const logUserIn = tokenQueryString => dispatch => fetch(
+  `${process.env.API_BASE_URL}/users/login${tokenQueryString}`
+)


Unexpected newline before ')' function-paren-newline

houndci-bot · 2018-12-20T16:42:45Z

src/actions/loginActions.js

+    }
+  });
+
+export const logUserIn = tokenQueryString => dispatch => fetch(


Unexpected newline after '(' function-paren-newline

houndci-bot · 2018-12-20T16:42:45Z

src/actions/loginActions.js

+
+export const sendEmailLink = email => dispatch => fetch(
+  `${process.env.API_BASE_URL}/users/login`, requestOptions({ email }, 'POST', null)
+)


Unexpected newline before ')' function-paren-newline

houndci-bot · 2018-12-20T16:42:46Z

src/actions/loginActions.js

+import { globalLoading, globalFailure, globalLoggedIn } from './globalActions';
+import requestOptions from '../utils/requestOptions';
+
+export const sendEmailLink = email => dispatch => fetch(


Unexpected newline after '(' function-paren-newline

- add tests - add login action creators - add welcome page component [Starts #161290964]

tersoo-atsen · 2018-12-20T18:50:42Z

@sulenchy this problem has been resolved. The problem was my review app had not been added to the Google developer console.

tersoo-atsen requested review from sulenchy, mbilesanmi, KvNGCzA, augustineezinwa and Darthrighteous December 19, 2018 14:50

KvNGCzA temporarily deployed to valinor-ah-frontend-stag-pr-31 December 19, 2018 14:50 Inactive

tersoo-atsen force-pushed the feature/161290964/local-login-feature branch from e314ee4 to 40a93cb Compare December 19, 2018 15:10

tersoo-atsen temporarily deployed to valinor-ah-frontend-stag-pr-31 December 19, 2018 15:11 Inactive

houndci-bot reviewed Dec 19, 2018

View reviewed changes

src/components/welcome/WelcomePage.js Show resolved Hide resolved

sulenchy suggested changes Dec 20, 2018

View reviewed changes

andela-moe reviewed Dec 20, 2018

View reviewed changes

src/actions/loginActions.js Outdated Show resolved Hide resolved

src/actions/loginActions.js Outdated Show resolved Hide resolved

tersoo-atsen force-pushed the feature/161290964/local-login-feature branch from 40a93cb to c65c952 Compare December 20, 2018 16:20

tersoo-atsen temporarily deployed to valinor-ah-frontend-stag-pr-31 December 20, 2018 16:21 Inactive

tersoo-atsen force-pushed the feature/161290964/local-login-feature branch from c65c952 to 459da6e Compare December 20, 2018 16:37

tersoo-atsen temporarily deployed to valinor-ah-frontend-stag-pr-31 December 20, 2018 16:37 Inactive

tersoo-atsen removed the request for review from mbilesanmi December 20, 2018 16:40

houndci-bot reviewed Dec 20, 2018

View reviewed changes

feat(login): local login feature

c3d6c71

- add tests - add login action creators - add welcome page component [Starts #161290964]

tersoo-atsen force-pushed the feature/161290964/local-login-feature branch from 459da6e to c3d6c71 Compare December 20, 2018 18:44

tersoo-atsen deployed to valinor-ah-frontend-stag-pr-31 December 20, 2018 18:44 View deployment

tersoo-atsen merged commit 41fdcc4 into develop Dec 21, 2018

tersoo-atsen deleted the feature/161290964/local-login-feature branch December 21, 2018 09:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#161290964 Build local login feature #31

#161290964 Build local login feature #31

tersoo-atsen commented Dec 19, 2018 •

edited

Loading

sulenchy left a comment

andela-moe left a comment

houndci-bot Dec 20, 2018

houndci-bot Dec 20, 2018

houndci-bot Dec 20, 2018

houndci-bot Dec 20, 2018

houndci-bot Dec 20, 2018

houndci-bot Dec 20, 2018

houndci-bot Dec 20, 2018

tersoo-atsen commented Dec 20, 2018 •

edited

Loading

#161290964 Build local login feature #31

#161290964 Build local login feature #31

Conversation

tersoo-atsen commented Dec 19, 2018 • edited Loading

What does this PR do?

Description of Task to be completed?

How should this be manually tested?

Any background context you want to provide?

What are the relevant pivotal tracker stories?

Screenshots (if appropriate)

Questions:

sulenchy left a comment

Choose a reason for hiding this comment

andela-moe left a comment

Choose a reason for hiding this comment

houndci-bot Dec 20, 2018

Choose a reason for hiding this comment

houndci-bot Dec 20, 2018

Choose a reason for hiding this comment

houndci-bot Dec 20, 2018

Choose a reason for hiding this comment

houndci-bot Dec 20, 2018

Choose a reason for hiding this comment

houndci-bot Dec 20, 2018

Choose a reason for hiding this comment

houndci-bot Dec 20, 2018

Choose a reason for hiding this comment

houndci-bot Dec 20, 2018

Choose a reason for hiding this comment

tersoo-atsen commented Dec 20, 2018 • edited Loading

tersoo-atsen commented Dec 19, 2018 •

edited

Loading

tersoo-atsen commented Dec 20, 2018 •

edited

Loading