#165674559 Fix social authentication logic to accommodate unique usernames #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ique usernames [Finishes #165674559]
Dubby20
approved these changes
Apr 29, 2019
youngestdj
approved these changes
Apr 29, 2019
codinger41
added
TTL review needed
codinger41
requested review from
9jaswag
and removed request for
youngestdj and
Dubby20
9jaswag
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix social authentication logic to accommodate unique usernames
Description of Task to be completed?
Google authentication fails when a user signs up with Google, with 2 google emails and the user has the same name. Now I wrote this logic to check if the username already exists. If the email and username matches, it'll move to the next logic of the controller.
How should this be manually tested?
Any background context you want to provide?
What are the relevant pivotal tracker stories?
https://www.pivotaltracker.com/story/show/165674559
Screenshots (if appropriate)
Questions:
N/A