-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#166263767 Travis and Coveralls integration #1
Conversation
2338e95
to
57247b4
Compare
- Update .travis.yml file - Update README - Integrate coverage - Add coveralls badge [#166263767]
57247b4
to
7600b1e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work integrating Travis and coveralls. Now we can have seamless integration knowing that our tests are passing and that the coverage is good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on configuring .travis.yml
to make sure that Travis builds and tests our App successfully. The README also shows the badges appropriately and gives an accurate score of the app's build status and coverage. Good job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite thoughtful to have only Travis and not both Travis and Circle CI since they serve the same function, and also integrating coveralls and the badges. This is okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and meets the required expectations.
Title
Travis and Coveralls integration
Description
Currently, we don't have a Travis and coveralls badge on the README. There is a need to have both Travis and coveralls integrated so that we can monitor our tests and the coverage.
Type of change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Task / Chore
This change requires a documentation update
How has this been Tested?
View the README on the
task/166263767-integrate-travis
branchChecklist
What are the relevant pivotal tracker stories?
https://www.pivotaltracker.com/story/show/166263767