Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

166263694 Upgrade to django2 #2

Merged
merged 1 commit into from
May 31, 2019
Merged

166263694 Upgrade to django2 #2

merged 1 commit into from
May 31, 2019

Conversation

Tevinthuku
Copy link
Contributor

@Tevinthuku Tevinthuku commented May 30, 2019 •
edited by bencyn
Loading

Title

Updating Django to version 2.2

Description

This PR updates the Django version of the project from v1 to v2.
The endpoints now work with the updated Django version.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

  • This change requires a documentation update

  • Task / Chore

How has this been tested?

  • End to End
  • Integration tests
  • Unit tests

Checklist:

  • - update django to version 2
  • - update DRF
  • - update url patterns accross apps
  • - create pull_request_template
  • - Fix Exercise Test errors
  • - Edit api/serializers
  • - set renderer=None to the render method in ExerciseAjaxSelect class
  • - Add locale
  • - fix middleware arrangements
  • - Update gym models

PT stories

#166263694

@misocho misocho force-pushed the task/166263694-upgrade-to-django-2 branch 2 times, most recently from c4324e8 to 766759f Compare May 30, 2019 16:17
@Tevinthuku Tevinthuku force-pushed the task/166263694-upgrade-to-django-2 branch 3 times, most recently from 82c00c6 to e5189c0 Compare May 31, 2019 06:55
@misocho misocho force-pushed the task/166263694-upgrade-to-django-2 branch 6 times, most recently from afdd24a to 68ca9a1 Compare May 31, 2019 08:17
166263694-chore(upgrade): upgrade to django2
be120f6 
- update django to version 2
- update DRF
- update url patterns accross apps
- create pull_request_template

- Fix Exercise Test errors

- Edit api/serializers

- set renderer=None to the render method in ExerciseAjaxSelect class

- Add locale
- fix middleware arrangements

- Update gym models
- Remove feedback failing test

- Update travis configuration
- Update gym models

[Finishes 166263694]
@martinMutuma martinMutuma force-pushed the task/166263694-upgrade-to-django-2 branch from 68ca9a1 to be120f6 Compare May 31, 2019 09:04
justMuriithi
justMuriithi approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@justMuriithi justMuriithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is superb work. The refactoring of all serializers to include fields was a great catch after upgrading to Django2. Great work also on updating the middleware. This PR looks good to go.

bencyn
bencyn approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@bencyn bencyn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Love how the urls were replaced with paths making the routes more readable and manageable.

misocho
misocho approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@misocho misocho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on upgrading the Django version from Django1 to Django2. All the running tests are passing 👍🏾

@bencyn bencyn requested a review from misocho May 31, 2019 09:59
Kimaiyo077
Kimaiyo077 approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@Kimaiyo077 Kimaiyo077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work on fixing the Travis.yml file and updating the requirements, to allow the builds to run successfully on Travis CI, with the updated version of Django and all its dependencies.

martinMutuma
martinMutuma approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@martinMutuma martinMutuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work from the team. The PR meets the requirements of the task. Upgrading from django.core.urlresolvers to the new django.url and Updating to paths is a plus. This is good to go.

@Tevinthuku
Copy link
Contributor Author

Tevinthuku commented May 31, 2019 •
edited
Loading

Thanks team #fortem @bencyn @martinMutuma @misocho @Kimaiyo077 @justMuriithi @michael-basweti for the awesome work you did to make sure that the upgrade was successful. This couldn't have been possible without your invaluable input on this task.

@michael-basweti michael-basweti self-requested a review May 31, 2019 10:28
michael-basweti
michael-basweti approved these changes May 31, 2019
View reviewed changes
Copy link
Contributor

@michael-basweti michael-basweti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, amazing work team

@michael-basweti michael-basweti merged commit 702f10c into develop May 31, 2019
@michael-basweti michael-basweti deleted the task/166263694-upgrade-to-django-2 branch June 7, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bencyn bencyn bencyn approved these changes

@martinMutuma martinMutuma martinMutuma approved these changes

@michael-basweti michael-basweti michael-basweti approved these changes

@Kimaiyo077 Kimaiyo077 Kimaiyo077 approved these changes

@justMuriithi justMuriithi justMuriithi approved these changes

@misocho misocho Awaiting requested review from misocho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Tevinthuku @bencyn @martinMutuma @michael-basweti @misocho @Kimaiyo077 @justMuriithi